1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
|
package recvcheck
import (
"go/ast"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/analysis/passes/inspect"
"golang.org/x/tools/go/ast/inspector"
)
var Analyzer = &analysis.Analyzer{
Name: "recvcheck",
Doc: "checks for receiver type consistency",
Run: run,
Requires: []*analysis.Analyzer{inspect.Analyzer},
}
func run(pass *analysis.Pass) (any, error) {
inspector := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
structs := map[string]*structType{}
inspector.Preorder([]ast.Node{(*ast.FuncDecl)(nil)}, func(n ast.Node) {
funcDecl, ok := n.(*ast.FuncDecl)
if !ok || funcDecl.Recv == nil || len(funcDecl.Recv.List) != 1 {
return
}
var recv *ast.Ident
var isStar bool
switch recvType := funcDecl.Recv.List[0].Type.(type) {
case *ast.StarExpr:
isStar = true
if recv, ok = recvType.X.(*ast.Ident); !ok {
return
}
case *ast.Ident:
recv = recvType
default:
return
}
var st *structType
st, ok = structs[recv.Name]
if !ok {
structs[recv.Name] = &structType{recv: recv.Name}
st = structs[recv.Name]
}
if isStar {
st.numStarMethod++
} else {
st.numTypeMethod++
}
})
for _, st := range structs {
if st.numStarMethod > 0 && st.numTypeMethod > 0 {
pass.Reportf(pass.Pkg.Scope().Lookup(st.recv).Pos(), "the methods of %q use pointer receiver and non-pointer receiver.", st.recv)
}
}
return nil, nil
}
type structType struct {
recv string
numStarMethod int
numTypeMethod int
}
|
