1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
|
# errchkjson
[](https://github.com/breml/errchkjson/actions/workflows/ci.yml) [](https://goreportcard.com/report/github.com/breml/errchkjson) [](LICENSE)
Checks types passed to the json encoding functions. Reports unsupported types and reports occurrences where the check for the returned error can be omitted.
Consider this [http.Handler](https://pkg.go.dev/net/http#Handler):
```Go
func JSONHelloWorld(w http.ResponseWriter, r *http.Request) {
response := struct {
Message string
Code int
}{
Message: "Hello World",
Code: 200,
}
body, err := json.Marshal(response)
if err != nil {
panic(err) // unreachable, because json encoding of a struct with just a string and an int will never return an error.
}
w.Write(body)
}
```
Because the `panic` is not possible to happen, one might refactor the code like this:
```Go
func JSONHelloWorld(w http.ResponseWriter, r *http.Request) {
response := struct {
Message string
Code int
}{
Message: "Hello World",
Code: 200,
}
body, _ := json.Marshal(response)
w.Write(body)
}
```
This is ok, as long as the struct is not altered in such a way, that could potentially lead
to `json.Marshal` returning an error.
`errchkjson` allows you to lint your code such that the above error returned from `json.Marshal`
can be omitted while still staying safe, because as soon as an unsafe type is added to the
response type, the linter will warn you.
## Installation
Download `errchkjson` from the [releases](https://github.com/breml/errchkjson/releases) or get the latest version from source with:
```shell
go install github.com/breml/errchkjson/cmd/errchkjson@latest
```
## Usage
### Shell
Check everything:
```shell
errchkjson ./...
```
`errchkjson` also recognizes the following command-line options:
The `-omit-safe` flag disables checking for safe returns of errors from json.Marshal
## Types
### Safe
The following types are safe to use with [json encoding functions](https://pkg.go.dev/encoding/json), that is, the encoding to JSON can not fail:
Safe basic types:
* `bool`
* `int`, `int8`, `int16`, `int32`, `int64`, `uint`, `uint8`, `uint16`, `uint32`, `uint64`, `uintptr`
* `string`
* Pointer type of the above listed basic types
Composed types (struct, map, slice, array) are safe, if the type of the value is
safe. For structs, only exported fields are relevant. For maps, the key needs to be either an integer type or a string.
### Unsafe
The following types are unsafe to use with [json encoding functions](https://pkg.go.dev/encoding/json), that is, the encoding to JSON can fail (return an error):
Unsafe basic types:
* `float32`, `float64`
* `interface{}`
* Pointer type of the above listed basic types
Any composed types (struct, map, slice, array) containing an unsafe basic type.
If a type implements the `json.Marshaler` or `encoding.TextMarshaler` interface (e.g. `json.Number`).
### Forbidden
Forbidden basic types:
* `complex64`, `complex128`
* `chan`
* `func`
* `unsafe.Pointer`
Any composed types (struct, map, slice, array) containing a forbidden basic type. Any map
using a key with a forbidden type (`bool`, `float32`, `float64`, `struct`).
## Accepted edge case
For `encoding/json.MarshalIndent`, there is a (pathological) edge case, where this
function could [return an error](https://cs.opensource.google/go/go/+/refs/tags/go1.18:src/encoding/json/scanner.go;drc=refs%2Ftags%2Fgo1.18;l=181) for an otherwise safe argument, if the argument has
a nesting depth larger than [`10000`](https://cs.opensource.google/go/go/+/refs/tags/go1.18:src/encoding/json/scanner.go;drc=refs%2Ftags%2Fgo1.18;l=144) (as of Go 1.18).
## Bugs found during development
During the development of `errcheckjson`, the following issues in package `encoding/json` of the Go standard library have been found and PR have been merged:
* [Issue #34154: encoding/json: string option (struct tag) on string field with SetEscapeHTML(false) escapes anyway](https://github.com/golang/go/issues/34154)
* [PR #34127: encoding/json: fix and optimize marshal for quoted string](https://github.com/golang/go/pull/34127)
* [Issue #34268: encoding/json: wrong encoding for json.Number field with string option (struct tag)](https://github.com/golang/go/issues/34268)
* [PR #34269: encoding/json: make Number with the ,string option marshal with quotes](https://github.com/golang/go/pull/34269)
* [PR #34272: encoding/json: validate strings when decoding into Number](https://github.com/golang/go/pull/34272)
|
