1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
|
// Copyright 2024 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package db
// TODO: split off some SeriesPatchesRepository.
import (
"context"
"errors"
"fmt"
"sync"
"time"
"cloud.google.com/go/spanner"
"github.com/google/uuid"
"google.golang.org/api/iterator"
)
type SeriesRepository struct {
client *spanner.Client
*genericEntityOps[Series, string]
}
func NewSeriesRepository(client *spanner.Client) *SeriesRepository {
return &SeriesRepository{
client: client,
genericEntityOps: &genericEntityOps[Series, string]{
client: client,
keyField: "ID",
table: "Series",
},
}
}
// TODO: move to SeriesPatchesRepository?
func (repo *SeriesRepository) PatchByID(ctx context.Context, id string) (*Patch, error) {
return readEntity[Patch](ctx, repo.client.Single(), spanner.Statement{
SQL: "SELECT * FROM Patches WHERE ID=@id",
Params: map[string]any{"id": id},
})
}
func (repo *SeriesRepository) GetByExtID(ctx context.Context, extID string) (*Series, error) {
return readEntity[Series](ctx, repo.client.Single(), spanner.Statement{
SQL: "SELECT * FROM Series WHERE ExtID=@extID",
Params: map[string]any{"extID": extID},
})
}
var ErrSeriesExists = errors.New("the series already exists")
// Insert() checks whether there already exists a series with the same ExtID.
// Since Patch content is stored elsewhere, we do not demand it be filled out before calling Insert().
// Instead, Insert() obtains this data via a callback.
func (repo *SeriesRepository) Insert(ctx context.Context, series *Series,
queryPatches func() ([]*Patch, error)) error {
var patches []*Patch
var patchesErr error
var patchesOnce sync.Once
doQueryPatches := func() {
if queryPatches == nil {
return
}
patches, patchesErr = queryPatches()
}
if series.ID == "" {
series.ID = uuid.NewString()
}
_, err := repo.client.ReadWriteTransaction(ctx,
func(ctx context.Context, txn *spanner.ReadWriteTransaction) error {
// Check if the series already exists.
stmt := spanner.Statement{
SQL: "SELECT 1 from `Series` WHERE `ExtID`=@extID",
Params: map[string]any{"ExtID": series.ExtID},
}
iter := txn.Query(ctx, stmt)
defer iter.Stop()
_, iterErr := iter.Next()
if iterErr == nil {
return ErrSeriesExists
} else if iterErr != iterator.Done {
return iterErr
}
// Query patches (once).
patchesOnce.Do(doQueryPatches)
if patchesErr != nil {
return patchesErr
}
// Save the objects.
var stmts []*spanner.Mutation
seriesStmt, err := spanner.InsertStruct("Series", series)
if err != nil {
return err
}
stmts = append(stmts, seriesStmt)
for _, patch := range patches {
patch.ID = uuid.NewString()
patch.SeriesID = series.ID
stmt, err := spanner.InsertStruct("Patches", patch)
if err != nil {
return err
}
stmts = append(stmts, stmt)
}
return txn.BufferWrite(stmts)
})
return err
}
func (repo *SeriesRepository) Count(ctx context.Context) (int, error) {
stmt := spanner.Statement{SQL: "SELECT COUNT(*) FROM `Series`"}
var count int64
err := repo.client.Single().Query(ctx, stmt).Do(func(row *spanner.Row) error {
return row.Column(0, &count)
})
return int(count), err
}
type SeriesWithSession struct {
Series *Series
Session *Session
Findings int
}
type SeriesFilter struct {
Cc string
Status SessionStatus
WithFindings bool
Limit int
Offset int
}
// ListLatest() returns the list of series ordered by the decreasing PublishedAt value.
func (repo *SeriesRepository) ListLatest(ctx context.Context, filter SeriesFilter,
maxPublishedAt time.Time) ([]*SeriesWithSession, error) {
ro := repo.client.ReadOnlyTransaction()
defer ro.Close()
stmt := spanner.Statement{
SQL: "SELECT Series.* FROM Series WHERE 1=1",
Params: map[string]any{},
}
if !maxPublishedAt.IsZero() {
stmt.SQL += " AND PublishedAt < @toTime"
stmt.Params["toTime"] = maxPublishedAt
}
if filter.Cc != "" {
stmt.SQL += " AND @cc IN UNNEST(Cc)"
stmt.Params["cc"] = filter.Cc
}
if filter.Status != SessionStatusAny {
// It could have been an INNER JOIN in the main query, but let's favor the simpler code
// in this function.
// The optimizer should transform the query to a JOIN anyway.
stmt.SQL += " AND EXISTS(SELECT 1 FROM Sessions WHERE"
switch filter.Status {
case SessionStatusWaiting:
stmt.SQL += " Sessions.SeriesID = Series.ID AND Sessions.StartedAt IS NULL"
case SessionStatusInProgress:
stmt.SQL += " Sessions.ID = Series.LatestSessionID AND Sessions.FinishedAt IS NULL"
case SessionStatusFinished:
stmt.SQL += " Sessions.ID = Series.LatestSessionID AND Sessions.FinishedAt IS NOT NULL" +
" AND Sessions.SkipReason IS NULL"
case SessionStatusSkipped:
stmt.SQL += " Sessions.ID = Series.LatestSessionID AND Sessions.SkipReason IS NOT NULL"
default:
return nil, fmt.Errorf("unknown status value: %q", filter.Status)
}
stmt.SQL += ")"
}
if filter.WithFindings {
stmt.SQL += " AND Series.LatestSessionID IS NOT NULL AND EXISTS(" +
"SELECT 1 FROM Findings WHERE " +
"Findings.SessionID = Series.LatestSessionID AND Findings.InvalidatedAt IS NULL)"
}
stmt.SQL += " ORDER BY PublishedAt DESC, ID"
if filter.Limit > 0 {
stmt.SQL += " LIMIT @limit"
stmt.Params["limit"] = filter.Limit
}
if filter.Offset > 0 {
stmt.SQL += " OFFSET @offset"
stmt.Params["offset"] = filter.Offset
}
seriesList, err := readEntities[Series](ctx, ro, stmt)
if err != nil {
return nil, err
}
// Now query Sessions.
var ret []*SeriesWithSession
for _, series := range seriesList {
obj := &SeriesWithSession{Series: series}
ret = append(ret, obj)
}
// And the rest of the data.
err = repo.querySessions(ctx, ro, ret)
if err != nil {
return nil, fmt.Errorf("failed to query sessions: %w", err)
}
err = repo.queryFindingCounts(ctx, ro, ret)
if err != nil {
return nil, fmt.Errorf("failed to query finding counts: %w", err)
}
return ret, nil
}
func (repo *SeriesRepository) querySessions(ctx context.Context, ro *spanner.ReadOnlyTransaction,
seriesList []*SeriesWithSession) error {
idToSeries := map[string]*SeriesWithSession{}
var keys []string
for _, item := range seriesList {
series := item.Series
idToSeries[series.ID] = item
if !series.LatestSessionID.IsNull() {
keys = append(keys, series.LatestSessionID.String())
}
}
if len(keys) == 0 {
return nil
}
sessions, err := readEntities[Session](ctx, ro, spanner.Statement{
SQL: "SELECT * FROM Sessions WHERE ID IN UNNEST(@ids)",
Params: map[string]any{
"ids": keys,
},
})
if err != nil {
return err
}
for _, session := range sessions {
obj := idToSeries[session.SeriesID]
if obj != nil {
obj.Session = session
}
}
return nil
}
func (repo *SeriesRepository) queryFindingCounts(ctx context.Context, ro *spanner.ReadOnlyTransaction,
seriesList []*SeriesWithSession) error {
var keys []string
sessionToSeries := map[string]*SeriesWithSession{}
for _, series := range seriesList {
if series.Session == nil || series.Session.Status() != SessionStatusFinished {
continue
}
keys = append(keys, series.Session.ID)
sessionToSeries[series.Session.ID] = series
}
if len(keys) == 0 {
return nil
}
type findingCount struct {
SessionID string `spanner:"SessionID"`
Count int64 `spanner:"Count"`
}
list, err := readEntities[findingCount](ctx, repo.client.Single(), spanner.Statement{
SQL: "SELECT `SessionID`, COUNT(`ID`) as `Count` FROM `Findings` " +
"WHERE `SessionID` IN UNNEST(@ids) AND `Findings`.`InvalidatedAt` IS NULL " +
"GROUP BY `SessionID`",
Params: map[string]any{
"ids": keys,
},
})
if err != nil {
return err
}
for _, item := range list {
sessionToSeries[item.SessionID].Findings = int(item.Count)
}
return nil
}
// golint sees too much similarity with SessionRepository's ListForSeries, but in reality there's not.
func (repo *SeriesRepository) ListPatches(ctx context.Context, series *Series) ([]*Patch, error) {
return readEntities[Patch](ctx, repo.client.Single(), spanner.Statement{
SQL: "SELECT * FROM `Patches` WHERE `SeriesID` = @seriesID ORDER BY `Seq`",
Params: map[string]any{
"seriesID": series.ID,
},
})
}
|