1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
|
// Copyright 2024 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package rpcserver
import (
"net"
"testing"
"github.com/stretchr/testify/assert"
"github.com/google/syzkaller/pkg/flatrpc"
"github.com/google/syzkaller/pkg/mgrconfig"
"github.com/google/syzkaller/pkg/rpcserver/mocks"
"github.com/google/syzkaller/prog"
"github.com/google/syzkaller/sys/targets"
)
func getTestDefaultCfg() mgrconfig.Config {
return mgrconfig.Config{
Type: targets.Linux,
Sandbox: "none",
Derived: mgrconfig.Derived{
TargetOS: targets.TestOS,
TargetArch: targets.TestArch64,
TargetVMArch: targets.TestArch64,
Timeouts: targets.Timeouts{Slowdown: 1},
},
}
}
func TestNew(t *testing.T) {
defaultCfg := getTestDefaultCfg()
nilServer := func(s Server) {
assert.Nil(t, s)
}
tests := []struct {
name string
modifyCfg func() *mgrconfig.Config
debug bool
expectedServCheck func(Server)
expectsErr bool
expectedErr error
}{
{
name: "unknown Sandbox",
modifyCfg: func() *mgrconfig.Config {
cfg := defaultCfg
cfg.Sandbox = "unknown"
return &cfg
},
expectedServCheck: nilServer,
expectsErr: true,
},
{
name: "experimental features",
modifyCfg: func() *mgrconfig.Config {
cfg := defaultCfg
cfg.Experimental = mgrconfig.Experimental{
RemoteCover: false,
CoverEdges: true,
}
return &cfg
},
expectedServCheck: func(srv Server) {
s := srv.(*server)
assert.Equal(t, s.cfg.Config.Features, flatrpc.AllFeatures&(^flatrpc.FeatureExtraCoverage))
assert.Nil(t, s.serv)
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
cfg := tt.modifyCfg()
var err error
cfg.Target, err = prog.GetTarget(cfg.TargetOS, cfg.TargetArch)
assert.NoError(t, err)
serv, err := New(&RemoteConfig{
Config: cfg,
Stats: NewStats(),
Debug: tt.debug,
})
if tt.expectedErr != nil {
assert.Equal(t, tt.expectedErr, err)
} else if tt.expectsErr {
assert.Error(t, err)
} else {
assert.Nil(t, err)
}
tt.expectedServCheck(serv)
})
}
}
func TestCheckRevisions(t *testing.T) {
tests := []struct {
name string
req *flatrpc.ConnectRequest
target *prog.Target
noError bool
}{
{
name: "error - different Arch",
req: &flatrpc.ConnectRequest{
Arch: "arch",
},
target: &prog.Target{
Arch: "arch2",
},
},
{
name: "error - different GitRevision",
req: &flatrpc.ConnectRequest{
Arch: "arch",
GitRevision: "different",
},
target: &prog.Target{
Arch: "arch",
},
},
{
name: "error - different SyzRevision",
req: &flatrpc.ConnectRequest{
Arch: "arch",
GitRevision: prog.GitRevision,
SyzRevision: "1",
},
target: &prog.Target{
Arch: "arch",
Revision: "2",
},
},
{
name: "ok",
req: &flatrpc.ConnectRequest{
Arch: "arch",
GitRevision: prog.GitRevision,
SyzRevision: "1",
},
target: &prog.Target{
Arch: "arch",
Revision: "1",
},
noError: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := checkRevisions(tt.req, tt.target)
if tt.noError {
assert.NoError(t, err)
} else {
assert.Error(t, err)
}
})
}
}
func TestHandleConn(t *testing.T) {
inConn, outConn := net.Pipe()
serverConn := flatrpc.NewConn(inConn)
clientConn := flatrpc.NewConn(outConn)
managerMock := mocks.NewManager(t)
debug := false
defaultCfg := getTestDefaultCfg()
tests := []struct {
name string
modifyCfg func() *mgrconfig.Config
req *flatrpc.ConnectRequest
}{
{
name: "error, cfg.VMLess = false - unknown VM tries to connect",
modifyCfg: func() *mgrconfig.Config {
return &defaultCfg
},
req: &flatrpc.ConnectRequest{
Id: 2, // Valid Runner id is 1.
Arch: "64",
GitRevision: prog.GitRevision,
SyzRevision: "1",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
cfg := tt.modifyCfg()
var err error
cfg.Target, err = prog.GetTarget(cfg.TargetOS, cfg.TargetArch)
cfg.Target.Revision = tt.req.SyzRevision
assert.NoError(t, err)
s, err := New(&RemoteConfig{
Config: cfg,
Manager: managerMock,
Stats: NewStats(),
Debug: debug,
})
assert.NoError(t, err)
serv := s.(*server)
injectExec := make(chan bool)
serv.CreateInstance(1, injectExec, nil)
go flatrpc.Send(clientConn, tt.req)
serv.handleConn(serverConn)
})
}
}
|