From fb190a7fb9202a30d6f8476d65e635320eb0d249 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 16 Oct 2015 22:21:02 +0200 Subject: remove ability to execute tests in parallel in fuzzer it consumes more memory and makes it difficult to find crashing input --- vm/qemu/qemu.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'vm') diff --git a/vm/qemu/qemu.go b/vm/qemu/qemu.go index 5d4a4e0f1..050109ee8 100644 --- a/vm/qemu/qemu.go +++ b/vm/qemu/qemu.go @@ -49,7 +49,6 @@ type params struct { Port int Cpu int Mem int - Parallel int } func ctor(workdir string, syscalls map[int]bool, port, index int, paramsData []byte) (vm.Instance, error) { @@ -82,12 +81,6 @@ func ctor(workdir string, syscalls map[int]bool, port, index int, paramsData []b if p.Mem < 128 || p.Mem > 1048576 { return nil, fmt.Errorf("bad qemu mem: %v, want [128-1048576]", p.Mem) } - if p.Parallel == 0 { - p.Parallel = 1 - } - if p.Parallel <= 0 || p.Parallel > 100 { - return nil, fmt.Errorf("bad parallel param: %v, want [1-100]", p.Parallel) - } crashdir := filepath.Join(workdir, "crashes") os.MkdirAll(crashdir, 0770) @@ -284,8 +277,8 @@ func (inst *Instance) Run() { inst.CreateSSHCommand("echo -n 0 > /proc/sys/debug/exception-trace").Wait(10 * time.Second) // Run the binary. - cmd := inst.CreateSSHCommand(fmt.Sprintf("/syzkaller_fuzzer -name %v -executor /syzkaller_executor -manager %v:%v -parallel %v %v", - inst.name, hostAddr, inst.mgrPort, inst.Parallel, inst.callsFlag)) + cmd := inst.CreateSSHCommand(fmt.Sprintf("/syzkaller_fuzzer -name %v -executor /syzkaller_executor -manager %v:%v %v", + inst.name, hostAddr, inst.mgrPort, inst.callsFlag)) deadline := start.Add(time.Hour) lastOutput := time.Now() -- cgit mrf-deployment