From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- vm/qemu/qemu.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'vm/qemu') diff --git a/vm/qemu/qemu.go b/vm/qemu/qemu.go index 222dc4d8a..15b8e0854 100644 --- a/vm/qemu/qemu.go +++ b/vm/qemu/qemu.go @@ -259,7 +259,7 @@ func ctor(env *vmimpl.Env) (vmimpl.Pool, error) { return nil, err } if env.Image == "9p" { - if env.OS != "linux" { + if env.OS != targets.Linux { return nil, fmt.Errorf("9p image is supported for linux only") } if cfg.Kernel == "" { -- cgit mrf-deployment