From a7ae31ed14a28ec2501e4113578ef3cee6020a75 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 19 Nov 2020 10:35:03 +0100 Subject: vm: pass Report to Diagnose The way to diagnose generally depends on the issue. E.g. do we need register dump to debug this issue? Do we need host dmesg dump? Some diagnosis may be directly specific to a particular problem (e.g. dumping a particular debugfs/procfs file). Pass Report to Diagnose to make this possible. --- vm/gce/gce.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'vm/gce') diff --git a/vm/gce/gce.go b/vm/gce/gce.go index e3f23ccee..b5565aff0 100644 --- a/vm/gce/gce.go +++ b/vm/gce/gce.go @@ -28,6 +28,7 @@ import ( "github.com/google/syzkaller/pkg/kd" "github.com/google/syzkaller/pkg/log" "github.com/google/syzkaller/pkg/osutil" + "github.com/google/syzkaller/pkg/report" "github.com/google/syzkaller/sys/targets" "github.com/google/syzkaller/vm/vmimpl" ) @@ -369,7 +370,7 @@ func waitForConsoleConnect(merger *vmimpl.OutputMerger) error { } } -func (inst *instance) Diagnose() ([]byte, bool) { +func (inst *instance) Diagnose(rep *report.Report) ([]byte, bool) { if inst.env.OS == targets.FreeBSD { return vmimpl.DiagnoseFreeBSD(inst.consolew) } -- cgit mrf-deployment