From e66542d78f1cf0c783877440cd239a11fb73fb15 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Mon, 12 Feb 2024 10:53:25 +0100 Subject: pkg/cover, syz-manager: introduce the /cover?debug=1 parameter Debugging coverage point validation warnings may require looking at specific addresses, which are not printed anywhere. Add a URL parameter that can be passed to prepareFileMap() to print a more meaningful error message. Also factor out the error message code from prepareFileMap() to reduce its cyclomatic complexity. --- tools/syz-cover/syz-cover.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'tools') diff --git a/tools/syz-cover/syz-cover.go b/tools/syz-cover/syz-cover.go index 40a77c72c..4023f3e5b 100644 --- a/tools/syz-cover/syz-cover.go +++ b/tools/syz-cover/syz-cover.go @@ -77,8 +77,13 @@ func main() { } progs := []cover.Prog{{PCs: pcs}} buf := new(bytes.Buffer) + params := cover.CoverHandlerParams{ + Progs: progs, + CoverFilter: nil, + Debug: false, + } if *flagExportCSV != "" { - if err := rg.DoCSV(buf, progs, nil); err != nil { + if err := rg.DoCSV(buf, params); err != nil { tool.Fail(err) } if err := osutil.WriteFile(*flagExportCSV, buf.Bytes()); err != nil { @@ -87,7 +92,7 @@ func main() { return } if *flagExportLineJSON != "" { - if err := rg.DoLineJSON(buf, progs, nil); err != nil { + if err := rg.DoLineJSON(buf, params); err != nil { tool.Fail(err) } if err := osutil.WriteFile(*flagExportLineJSON, buf.Bytes()); err != nil { @@ -95,7 +100,7 @@ func main() { } return } - if err := rg.DoHTML(buf, progs, nil); err != nil { + if err := rg.DoHTML(buf, params); err != nil { tool.Fail(err) } if *flagExportHTML != "" { -- cgit mrf-deployment