From d4c58caef7e5fbae992399cb3b28681694468b39 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 10 Jul 2020 17:44:14 +0200 Subject: tools/syz-linter: enable some standard linters Enable some x/tools linters that are not enabled in vet. Update #1876 --- tools/syz-linter/linter.go | 11 +++++++++++ tools/syz-reporter/reporter.go | 4 ---- 2 files changed, 11 insertions(+), 4 deletions(-) (limited to 'tools') diff --git a/tools/syz-linter/linter.go b/tools/syz-linter/linter.go index a19bfa3f4..d69ca0a2a 100644 --- a/tools/syz-linter/linter.go +++ b/tools/syz-linter/linter.go @@ -25,6 +25,11 @@ import ( "unicode" "golang.org/x/tools/go/analysis" + "golang.org/x/tools/go/analysis/passes/atomicalign" + "golang.org/x/tools/go/analysis/passes/copylock" + "golang.org/x/tools/go/analysis/passes/deepequalerrors" + "golang.org/x/tools/go/analysis/passes/nilness" + "golang.org/x/tools/go/analysis/passes/structtag" ) var AnalyzerPlugin analyzerPlugin @@ -38,6 +43,12 @@ func main() { func (*analyzerPlugin) GetAnalyzers() []*analysis.Analyzer { return []*analysis.Analyzer{ SyzAnalyzer, + // Some standard analyzers that are not enabled in vet. + atomicalign.Analyzer, + copylock.Analyzer, + deepequalerrors.Analyzer, + nilness.Analyzer, + structtag.Analyzer, } } diff --git a/tools/syz-reporter/reporter.go b/tools/syz-reporter/reporter.go index 5657d2eb9..948809ea7 100644 --- a/tools/syz-reporter/reporter.go +++ b/tools/syz-reporter/reporter.go @@ -131,10 +131,6 @@ func readCrash(workdir, dir string) *UICrashType { return nil } desc := string(trimNewLines(descBytes)) - if err != nil { - return nil - } - descFile.Close() files, err := osutil.ListDir(filepath.Join(crashdir, dir)) -- cgit mrf-deployment