From 514a302df7b2437100847d85646426c56a359e3b Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Wed, 2 Apr 2025 10:59:58 +0200 Subject: tools/syz-covermerger: fix nil deref Empty flagToGCS means nil WriteCloser. --- tools/syz-covermerger/syz_covermerger.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'tools') diff --git a/tools/syz-covermerger/syz_covermerger.go b/tools/syz-covermerger/syz_covermerger.go index 196c4982d..6cd714421 100644 --- a/tools/syz-covermerger/syz_covermerger.go +++ b/tools/syz-covermerger/syz_covermerger.go @@ -124,10 +124,11 @@ func do() error { if err != nil { return fmt.Errorf("covermerger.MergeCSVWriteJSONL: %w", err) } - if err := wc.Close(); err != nil { - return fmt.Errorf("wc.Close: %w", err) + if wc != nil { + if err := wc.Close(); err != nil { + return fmt.Errorf("wc.Close: %w", err) + } } - printCoverage(totalInstrumentedLines, totalCoveredLines) if *flagToDashAPI != "" { // Merging may take hours. It is better to create new connection instead of reuse. -- cgit mrf-deployment