From 3f8fbc095dfc200f862a823b1a61bf41c68e9338 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Tue, 22 Apr 2025 16:51:15 +0200 Subject: tools/syz-kconf: don't proceed after failures It's almost never reasonable to keep on generating configs after some targets have already failed. We have a lot of different kernels and regenerating them all takes a very long time. Having to regenerate everything on each iteration slows down the development significantly. --- tools/syz-kconf/kconf.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'tools') diff --git a/tools/syz-kconf/kconf.go b/tools/syz-kconf/kconf.go index 9ba2bff06..5a8808a11 100644 --- a/tools/syz-kconf/kconf.go +++ b/tools/syz-kconf/kconf.go @@ -62,7 +62,6 @@ func main() { tool.Fail(err) } // In order to speed up the process we generate instances that use the same kernel revision in parallel. - failed := false generated := make(map[string]bool) for _, inst := range instances { // Find the first instance that we did not generate yet. @@ -103,15 +102,16 @@ func main() { results <- nil }() } + failed := false for i := 0; i < batch; i++ { if err := <-results; err != nil { fmt.Printf("%v\n", err) failed = true } } - } - if failed { - tool.Failf("some configs failed") + if failed { + tool.Failf("some configs failed") + } } if len(generated) == 0 { tool.Failf("unknown instance name") -- cgit mrf-deployment