From 9fca97cadd2e63056f40e69d80ca1e798b2a18e8 Mon Sep 17 00:00:00 2001
From: Aleksandr Nogikh <nogikh@google.com>
Date: Thu, 25 Nov 2021 17:55:58 +0000
Subject: tools/syz-testbed: introduce a special type for table

This simplifies table generation and will let us more easily implement
relative difference and p-value calculation and printing.
---
 tools/syz-testbed/html.go | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

(limited to 'tools/syz-testbed/html.go')

diff --git a/tools/syz-testbed/html.go b/tools/syz-testbed/html.go
index fa3786cd4..196c12a3c 100644
--- a/tools/syz-testbed/html.go
+++ b/tools/syz-testbed/html.go
@@ -12,7 +12,6 @@ import (
 	"net"
 	"net/http"
 	"os"
-	"sort"
 	"time"
 
 	"github.com/google/syzkaller/pkg/html"
@@ -103,12 +102,12 @@ func (ctx *TestbedContext) httpGraph(w http.ResponseWriter, r *http.Request) {
 
 type uiStatView struct {
 	Name  string
-	Table [][]string
+	Table *Table
 }
 
 type uiMainPage struct {
 	Name    string
-	Summary [][]string
+	Summary *Table
 	Views   []uiStatView
 }
 
@@ -125,12 +124,6 @@ func (ctx *TestbedContext) httpMain(w http.ResponseWriter, r *http.Request) {
 			log.Printf("stat table generation failed: %s", err)
 			continue
 		}
-		sort.SliceStable(table, func(i, j int) bool {
-			if len(table[i]) == 0 || len(table[j]) == 0 {
-				return i < j
-			}
-			return table[i][0] < table[j][0]
-		})
 		uiViews = append(uiViews, uiStatView{
 			Name:  view.Name,
 			Table: table,
@@ -167,12 +160,19 @@ var mainTemplate = html.CreatePage(`
 {{define "Table"}}
 {{if .}}
 <table class="list_table">
-	{{range $c := .}}
 	<tr>
-	{{range $v := $c}}
-		<td>{{$v}}</td>
+	<th>{{.TopLeftHeader}}</th>
+	{{range $c := .ColumnHeaders}}
+		<th>{{$c}}</th>
 	{{end}}
 	</tr>
+	{{range $r := .SortedRows}}
+	<tr>
+		<td>{{$r}}</td>
+		{{range $c := $.ColumnHeaders}}
+			<td>{{$.Get $r $c}}</td>
+		{{end}}
+	</tr>
 	{{end}}
 </table>
 {{end}}
-- 
cgit mrf-deployment