From d77f428f8d1a224f7aa8085a5ce10083267b0ae6 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 10 Apr 2025 18:53:08 +0200 Subject: tools/syz-benchcmp: don't start browser if -out is set The -out option is used by syz-testbed, which only needs the output. --- tools/syz-benchcmp/benchcmp.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'tools/syz-benchcmp') diff --git a/tools/syz-benchcmp/benchcmp.go b/tools/syz-benchcmp/benchcmp.go index 646a93614..81bd0b900 100644 --- a/tools/syz-benchcmp/benchcmp.go +++ b/tools/syz-benchcmp/benchcmp.go @@ -23,7 +23,7 @@ import ( var ( flagAll = flag.Bool("all", false, "draw graphs for all variables") - flagOut = flag.String("out", "", "file to save graphs to; if empty, a random name will be generated") + flagOut = flag.String("out", "", "save the graph into the file instead of starting the browser") flagOver = flag.String("over", "fuzzing", "the variable that lies on the X axis") flagSkip = flag.Int("skip", -30, "skip that many seconds after start (skip first 20% by default)") ) @@ -241,8 +241,10 @@ func display(graphs []*Graph) { tool.Failf("failed to execute template: %v", err) } outf.Close() - if err := exec.Command("xdg-open", outf.Name()).Start(); err != nil { - tool.Failf("failed to start browser: %v", err) + if *flagOut == "" { + if err := exec.Command("xdg-open", outf.Name()).Start(); err != nil { + tool.Failf("failed to start browser: %v", err) + } } } -- cgit mrf-deployment