From de040344f89656862b5bbd306b8a9c143dae3dea Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Mon, 2 Aug 2021 17:08:58 +0000 Subject: pkg/report: separate reporter wrapper from OS-specific implementations Currently a number of report post-processing activities are implemented as a decorator over the interface that defines OS-specific implementations. Following exactly the same interface is too restrictive in this case as adding extra parameters to the post-processing forces the developer to adjust all implementations thay may not need these parameters at all. Untie the wrapper from the Reporter interface. Use a package-private reporterImpl interface for the OS-specific implementations, while having an exported Reporter structure. Make sure that Reporter is stored and passed as a pointer. --- syz-verifier/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'syz-verifier') diff --git a/syz-verifier/main.go b/syz-verifier/main.go index eea9d92ed..0a047231d 100755 --- a/syz-verifier/main.go +++ b/syz-verifier/main.go @@ -83,7 +83,7 @@ type RPCServer struct { type poolInfo struct { cfg *mgrconfig.Config pool *vm.Pool - Reporter report.Reporter + Reporter *report.Reporter // runners keeps track of what programs have been sent to each Runner. // There is one Runner executing per VM instance. runners map[int]runnerProgs -- cgit mrf-deployment