From 102e004727c29072e43dd2c85db7716bdb8d6878 Mon Sep 17 00:00:00 2001
From: Aleksandr Nogikh <nogikh@google.com>
Date: Mon, 13 Jan 2025 19:37:36 +0100
Subject: all: support empty HTTP config

We don't really need an HTTP server when running syz-manager during kernel
image testing and when running syz-diff automatically.

Don't require the config to be set and don't start the HTTP server in
this case.
---
 syz-manager/manager.go | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

(limited to 'syz-manager')

diff --git a/syz-manager/manager.go b/syz-manager/manager.go
index 1c86668f1..e093f7732 100644
--- a/syz-manager/manager.go
+++ b/syz-manager/manager.go
@@ -282,6 +282,7 @@ func RunManager(mode *Mode, cfg *mgrconfig.Config) {
 		mgr.cfg.Procs = 1
 	}
 	mgr.http = &manager.HTTPServer{
+		// Note that if cfg.HTTP == "", we don't start the server.
 		Cfg:        cfg,
 		StartTime:  time.Now(),
 		CrashStore: mgr.crashStore,
@@ -355,7 +356,9 @@ func RunManager(mode *Mode, cfg *mgrconfig.Config) {
 	mgr.http.TogglePause = mgr.pool.TogglePause
 
 	ctx := vm.ShutdownCtx()
-	go mgr.http.Serve()
+	if mgr.cfg.HTTP != "" {
+		go mgr.http.Serve()
+	}
 	go mgr.trackUsedFiles()
 	go mgr.processFuzzingResults(ctx)
 	mgr.pool.Loop(ctx)
@@ -1437,6 +1440,9 @@ func (mgr *Manager) CoverageFilter(modules []*vminfo.KernelModule) []uint64 {
 }
 
 func publicWebAddr(addr string) string {
+	if addr == "" {
+		return ""
+	}
 	_, port, err := net.SplitHostPort(addr)
 	if err == nil && port != "" {
 		if host, err := os.Hostname(); err == nil {
-- 
cgit mrf-deployment