From 5cdbe12ef7ec1ee2d99c5430924aab23c0fea503 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 2 Jan 2026 15:15:21 +0100 Subject: all: remove unused nolint directives --- syz-cluster/dashboard/handler.go | 1 - syz-cluster/pkg/db/finding_repo.go | 1 - syz-cluster/pkg/db/report_repo.go | 1 - syz-cluster/pkg/db/series_repo.go | 3 --- syz-cluster/pkg/db/session_repo.go | 1 - syz-cluster/pkg/reporter/api.go | 1 - 6 files changed, 8 deletions(-) (limited to 'syz-cluster') diff --git a/syz-cluster/dashboard/handler.go b/syz-cluster/dashboard/handler.go index 537e54136..d8ebd7c61 100644 --- a/syz-cluster/dashboard/handler.go +++ b/syz-cluster/dashboard/handler.go @@ -302,7 +302,6 @@ func (h *dashboardHandler) patchContent(w http.ResponseWriter, r *http.Request) return h.streamBlob(w, patch.BodyURI) } -// nolint:dupl func (h *dashboardHandler) allPatches(w http.ResponseWriter, r *http.Request) error { ctx := r.Context() series, err := h.seriesRepo.GetByID(ctx, r.PathValue("id")) diff --git a/syz-cluster/pkg/db/finding_repo.go b/syz-cluster/pkg/db/finding_repo.go index afcc559b1..20e9b43d9 100644 --- a/syz-cluster/pkg/db/finding_repo.go +++ b/syz-cluster/pkg/db/finding_repo.go @@ -101,7 +101,6 @@ func (repo *FindingRepository) mustStore(ctx context.Context, finding *Finding) }) } -// nolint: dupl func (repo *FindingRepository) ListForSession(ctx context.Context, sessionID string, limit int) ([]*Finding, error) { stmt := spanner.Statement{ SQL: "SELECT * FROM `Findings` WHERE `SessionID` = @session ORDER BY `TestName`, `Title`", diff --git a/syz-cluster/pkg/db/report_repo.go b/syz-cluster/pkg/db/report_repo.go index 28ca3a89a..d4b3286e9 100644 --- a/syz-cluster/pkg/db/report_repo.go +++ b/syz-cluster/pkg/db/report_repo.go @@ -50,7 +50,6 @@ func (repo *ReportRepository) Insert(ctx context.Context, rep *SessionReport) er return fmt.Errorf("failed to pick a non-existing report ID") } -// nolint: dupl func (repo *ReportRepository) ListNotReported(ctx context.Context, reporter string, limit int) ([]*SessionReport, error) { stmt := spanner.Statement{ diff --git a/syz-cluster/pkg/db/series_repo.go b/syz-cluster/pkg/db/series_repo.go index bb8bf7a8d..0adbf3900 100644 --- a/syz-cluster/pkg/db/series_repo.go +++ b/syz-cluster/pkg/db/series_repo.go @@ -34,7 +34,6 @@ func NewSeriesRepository(client *spanner.Client) *SeriesRepository { } // TODO: move to SeriesPatchesRepository? -// nolint:dupl func (repo *SeriesRepository) PatchByID(ctx context.Context, id string) (*Patch, error) { return readEntity[Patch](ctx, repo.client.Single(), spanner.Statement{ SQL: "SELECT * FROM Patches WHERE ID=@id", @@ -42,7 +41,6 @@ func (repo *SeriesRepository) PatchByID(ctx context.Context, id string) (*Patch, }) } -// nolint:dupl func (repo *SeriesRepository) GetByExtID(ctx context.Context, extID string) (*Series, error) { return readEntity[Series](ctx, repo.client.Single(), spanner.Statement{ SQL: "SELECT * FROM Series WHERE ExtID=@extID", @@ -279,7 +277,6 @@ func (repo *SeriesRepository) queryFindingCounts(ctx context.Context, ro *spanne } // golint sees too much similarity with SessionRepository's ListForSeries, but in reality there's not. -// nolint:dupl func (repo *SeriesRepository) ListPatches(ctx context.Context, series *Series) ([]*Patch, error) { return readEntities[Patch](ctx, repo.client.Single(), spanner.Statement{ SQL: "SELECT * FROM `Patches` WHERE `SeriesID` = @seriesID ORDER BY `Seq`", diff --git a/syz-cluster/pkg/db/session_repo.go b/syz-cluster/pkg/db/session_repo.go index 583a5f4af..2ec81759e 100644 --- a/syz-cluster/pkg/db/session_repo.go +++ b/syz-cluster/pkg/db/session_repo.go @@ -110,7 +110,6 @@ func (repo *SessionRepository) ListWaiting(ctx context.Context, from *NextSessio } // golint sees too much similarity with SeriesRepository's ListPatches, but in reality there's not. -// nolint:dupl func (repo *SessionRepository) ListForSeries(ctx context.Context, series *Series) ([]*Session, error) { return repo.readEntities(ctx, spanner.Statement{ SQL: "SELECT * FROM `Sessions` WHERE `SeriesID` = @series ORDER BY CreatedAt DESC", diff --git a/syz-cluster/pkg/reporter/api.go b/syz-cluster/pkg/reporter/api.go index 192ea693d..f12baf216 100644 --- a/syz-cluster/pkg/reporter/api.go +++ b/syz-cluster/pkg/reporter/api.go @@ -38,7 +38,6 @@ func (s *APIServer) Mux() *http.ServeMux { return mux } -// nolint: dupl func (s *APIServer) upstreamReport(w http.ResponseWriter, r *http.Request) { req := api.ParseJSON[api.UpstreamReportReq](w, r) if req == nil { -- cgit mrf-deployment