From 77230c294a419a97f63f155760d210bed1bc26a8 Mon Sep 17 00:00:00 2001 From: Taras Madan Date: Thu, 4 Apr 2024 15:00:58 +0200 Subject: syz-ci/manager.go: don't upload empty reports I observe the reports with 0 len. I'm sure it happens because of the connection timeouts etc. --- syz-ci/manager.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'syz-ci') diff --git a/syz-ci/manager.go b/syz-ci/manager.go index 2a5d2c196..542d3950e 100644 --- a/syz-ci/manager.go +++ b/syz-ci/manager.go @@ -879,9 +879,15 @@ func (mgr *Manager) uploadCoverStat(fuzzingMinutes int) error { resp, err := mgr.httpGET("/cover?jsonl=1") if err != nil { - return fmt.Errorf("failed to get /cover?json=1 report: %w", err) + return fmt.Errorf("failed to httpGet /cover?jsonl=1 report: %w", err) } defer resp.Body.Close() + if resp.StatusCode != http.StatusOK { + sb := new(strings.Builder) + io.Copy(sb, resp.Body) + return fmt.Errorf("failed to GET /cover?jsonl=1, httpStatus %d: %s", + resp.StatusCode, sb.String()) + } curTime := time.Now() pr, pw := io.Pipe() @@ -915,8 +921,7 @@ func (mgr *Manager) uploadCoverStat(fuzzingMinutes int) error { mgr.mgrcfg.DashboardClient, mgr.name, curTime.Format(time.DateOnly), curTime.Hour(), curTime.Minute()) - err = mgr.uploadFile(mgr.cfg.CoverPipelinePath, fileName, pr, false) - if err != nil { + if err := mgr.uploadFile(mgr.cfg.CoverPipelinePath, fileName, pr, false); err != nil { return fmt.Errorf("failed to uploadFileGCS(): %w", err) } return nil -- cgit mrf-deployment