From 85b1f93f8dbbc767c564e494a6353aa3517d5d49 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 16 Oct 2017 12:18:50 +0200 Subject: executor, pkg/ipc: unify ipc protocol between linux and other OSes We currently use more complex and functional protocol on linux, and a simple ad-hoc protocol on other OSes. This leads to code duplication in both ipc and executor. Linux supports coverage, shared memory communication and fork server, which would also be useful for most other OSes. Unify communication protocol and parametrize it by (1) use of shmem or only pipes, (2) use of fork server. This reduces duplication in ipc and executor and will allow to support the useful features for other OSes easily. Finally, this fixes akaros support as it currently uses syz-stress running on host (linux) and executor running on akaros. --- sys/targets/targets.go | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) (limited to 'sys') diff --git a/sys/targets/targets.go b/sys/targets/targets.go index 042637306..4ec176b46 100644 --- a/sys/targets/targets.go +++ b/sys/targets/targets.go @@ -24,6 +24,11 @@ type os struct { SyscallNumbers bool // E.g. "__NR_" or "SYS_". SyscallPrefix string + // ipc<->executor communication tuning. + // If ExecutorUsesShmem, programs and coverage are passed through shmem, otherwise via pipes. + ExecutorUsesShmem bool + // If ExecutorUsesForkServer, executor uses extended protocol with handshake. + ExecutorUsesForkServer bool } var List = map[string]map[string]*Target{ @@ -111,22 +116,32 @@ var List = map[string]map[string]*Target{ var oses = map[string]os{ "linux": { - SyscallNumbers: true, - SyscallPrefix: "__NR_", + SyscallNumbers: true, + SyscallPrefix: "__NR_", + ExecutorUsesShmem: true, + ExecutorUsesForkServer: true, }, "freebsd": { - SyscallNumbers: true, - SyscallPrefix: "SYS_", + SyscallNumbers: true, + SyscallPrefix: "SYS_", + ExecutorUsesShmem: false, + ExecutorUsesForkServer: false, }, "fuchsia": { - SyscallNumbers: false, + SyscallNumbers: false, + ExecutorUsesShmem: false, + ExecutorUsesForkServer: false, }, "windows": { - SyscallNumbers: false, + SyscallNumbers: false, + ExecutorUsesShmem: false, + ExecutorUsesForkServer: false, }, "akaros": { - SyscallNumbers: true, - SyscallPrefix: "SYS_", + SyscallNumbers: true, + SyscallPrefix: "SYS_", + ExecutorUsesShmem: false, + ExecutorUsesForkServer: false, }, } -- cgit mrf-deployment