From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- sys/openbsd/init_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sys/openbsd/init_test.go') diff --git a/sys/openbsd/init_test.go b/sys/openbsd/init_test.go index 7f3d9a489..3a6c2c14c 100644 --- a/sys/openbsd/init_test.go +++ b/sys/openbsd/init_test.go @@ -8,10 +8,11 @@ import ( "github.com/google/syzkaller/prog" _ "github.com/google/syzkaller/sys/openbsd/gen" + "github.com/google/syzkaller/sys/targets" ) func TestNeutralize(t *testing.T) { - prog.TestDeserializeHelper(t, "openbsd", "amd64", nil, []prog.DeserializeTest{ + prog.TestDeserializeHelper(t, targets.OpenBSD, targets.AMD64, nil, []prog.DeserializeTest{ { In: `chflagsat(0x0, 0x0, 0x60004, 0x0)`, Out: `chflagsat(0x0, 0x0, 0x0, 0x0)`, -- cgit mrf-deployment