From e54e9781a4e043b3140b0c908ba4f4e469fd317e Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sun, 26 Apr 2020 14:14:14 +0200 Subject: prog: remove Dir from Type Having Dir is Type is handy, but forces us to duplicate lots of types. E.g. if a struct is referenced as both in and out, then we need to have 2 copies and 2 copies of structs/types it includes. If also prevents us from having the struct type as struct identity (because we can have up to 3 of them). Revert to the old way we used to do it: propagate Dir as we walk syscall arguments. This moves lots of dir passing from pkg/compiler to prog package. Now Arg contains the dir, so once we build the tree, we can use dirs as before. Reduces size of sys/linux/gen/amd64.go from 6058336 to 5661150 (-6.6%). Update #1580 --- sys/linux/init_vusb.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sys/linux/init_vusb.go') diff --git a/sys/linux/init_vusb.go b/sys/linux/init_vusb.go index 7a61b0942..fc847be41 100644 --- a/sys/linux/init_vusb.go +++ b/sys/linux/init_vusb.go @@ -50,11 +50,11 @@ type HidDeviceID struct { Product uint32 } -func (arch *arch) generateUsbDeviceDescriptor(g *prog.Gen, typ0 prog.Type, old prog.Arg) ( +func (arch *arch) generateUsbDeviceDescriptor(g *prog.Gen, typ0 prog.Type, dir prog.Dir, old prog.Arg) ( arg prog.Arg, calls []*prog.Call) { if old == nil { - arg = g.GenerateSpecialArg(typ0, &calls) + arg = g.GenerateSpecialArg(typ0, dir, &calls) } else { arg = old calls = g.MutateArg(arg) @@ -140,11 +140,11 @@ func randUsbDeviceID(g *prog.Gen) UsbDeviceID { return id } -func (arch *arch) generateUsbHidDeviceDescriptor(g *prog.Gen, typ0 prog.Type, old prog.Arg) ( +func (arch *arch) generateUsbHidDeviceDescriptor(g *prog.Gen, typ0 prog.Type, dir prog.Dir, old prog.Arg) ( arg prog.Arg, calls []*prog.Call) { if old == nil { - arg = g.GenerateSpecialArg(typ0, &calls) + arg = g.GenerateSpecialArg(typ0, dir, &calls) } else { arg = old calls = g.MutateArg(arg) -- cgit mrf-deployment