From 31a30fc092d1c25b565a00465f075408677e8c54 Mon Sep 17 00:00:00 2001 From: Vikram Narayanan Date: Wed, 27 Oct 2021 00:52:34 -0700 Subject: sys/linux: neutralize ioctl for /dev/msr --- sys/linux/init.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'sys/linux/init.go') diff --git a/sys/linux/init.go b/sys/linux/init.go index 24d978381..88bfe919e 100644 --- a/sys/linux/init.go +++ b/sys/linux/init.go @@ -48,8 +48,10 @@ func InitTarget(target *prog.Target) { TIOCSSERIAL: target.GetConst("TIOCSSERIAL"), TIOCGSERIAL: target.GetConst("TIOCGSERIAL"), // These are not present on all arches. - ARCH_SET_FS: target.ConstMap["ARCH_SET_FS"], - ARCH_SET_GS: target.ConstMap["ARCH_SET_GS"], + ARCH_SET_FS: target.ConstMap["ARCH_SET_FS"], + ARCH_SET_GS: target.ConstMap["ARCH_SET_GS"], + X86_IOC_RDMSR_REGS: target.ConstMap["X86_IOC_RDMSR_REGS"], + X86_IOC_WRMSR_REGS: target.ConstMap["X86_IOC_WRMSR_REGS"], } target.MakeDataMmap = targets.MakePosixMmap(target, true, true) @@ -158,6 +160,8 @@ type arch struct { USB_MAJOR uint64 TIOCSSERIAL uint64 TIOCGSERIAL uint64 + X86_IOC_RDMSR_REGS uint64 + X86_IOC_WRMSR_REGS uint64 } func (arch *arch) neutralize(c *prog.Call) { @@ -284,6 +288,12 @@ func (arch *arch) neutralizeIoctl(c *prog.Call) { // and would be nice to test, if/when we can neutralize based on sandbox value // we could prohibit it only under sandbox=none. cmd.Val = arch.TIOCGSERIAL + case arch.X86_IOC_WRMSR_REGS: + // Enabling X86_IOC_WRMSR_REGS would cause havoc as it can write to any MSR registers + // and there are a lot of things that could go wrong. + // TODO: Ideally, it would be great if we can have a restricted set of inputs for this + // such that we can write values only from that set. + cmd.Val = arch.X86_IOC_RDMSR_REGS } } -- cgit mrf-deployment