From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- prog/test/fuzz.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'prog') diff --git a/prog/test/fuzz.go b/prog/test/fuzz.go index f3742f6c3..0d2807f7f 100644 --- a/prog/test/fuzz.go +++ b/prog/test/fuzz.go @@ -9,6 +9,7 @@ import ( "math/rand" "github.com/google/syzkaller/prog" + "github.com/google/syzkaller/sys/targets" _ "github.com/google/syzkaller/sys/test/gen" // import the target we use for fuzzing ) @@ -66,7 +67,7 @@ func FuzzParseLog(data []byte) int { var fuzzBuffer = make([]byte, prog.ExecBufferSize) var fuzzTarget, fuzzChoiceTable = func() (*prog.Target, *prog.ChoiceTable) { prog.Debug() - target, err := prog.GetTarget("test", "64") + target, err := prog.GetTarget(targets.TestOS, targets.TestArch64) if err != nil { panic(err) } -- cgit mrf-deployment