From 4eda9b07e5f25565333fdd8eed4e33850bd0f828 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 28 Dec 2015 12:58:10 +0100 Subject: prog: don't serialize paddings Paddings in serialized programs are unnecessary and confusing. Instead restore them implicitly. Also use [,,,,] for arrays. --- prog/validation.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'prog/validation.go') diff --git a/prog/validation.go b/prog/validation.go index a06f98de6..cc6d1ae61 100644 --- a/prog/validation.go +++ b/prog/validation.go @@ -18,12 +18,6 @@ func (p *Prog) validate() error { ctx := &validCtx{make(map[*Arg]bool), make(map[*Arg]*Arg)} for _, c := range p.Calls { if err := c.validate(ctx); err != nil { - - fmt.Printf("PROGRAM:\n") - for _, c := range p.Calls { - fmt.Printf(" %v: %+v %p\n", c.Meta.Name, c.Args, c.Ret) - } - return err } } @@ -36,6 +30,9 @@ func (p *Prog) validate() error { } func (c *Call) validate(ctx *validCtx) error { + if c.Meta == nil { + return fmt.Errorf("call does not have meta information") + } if len(c.Args) != len(c.Meta.Args) { return fmt.Errorf("syscall %v: wrong number of arguments, want %v, got %v", c.Meta.Name, len(c.Meta.Args), len(c.Args)) } -- cgit mrf-deployment