From 52a33fd516102a98d3753bf69417235b655a68dc Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 14 Sep 2017 19:25:01 +0200 Subject: prog: remove default target and all global state Now each prog function accepts the desired target explicitly. No global, implicit state involved. This is much cleaner and allows cross-OS/arch testing, etc. --- prog/parse_test.go | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) (limited to 'prog/parse_test.go') diff --git a/prog/parse_test.go b/prog/parse_test.go index 2f5dd75d6..aae1e0a17 100644 --- a/prog/parse_test.go +++ b/prog/parse_test.go @@ -8,10 +8,14 @@ import ( ) func TestParseSingle(t *testing.T) { + target, err := GetTarget("linux", "amd64") + if err != nil { + t.Fatal(err) + } const execLog = `getpid() gettid() ` - entries := ParseLog([]byte(execLog)) + entries := target.ParseLog([]byte(execLog)) if len(entries) != 1 { t.Fatalf("got %v programs, want 1", len(entries)) } @@ -36,7 +40,11 @@ gettid() } func TestParseMulti(t *testing.T) { - entries := ParseLog([]byte(execLog)) + target, err := GetTarget("linux", "amd64") + if err != nil { + t.Fatal(err) + } + entries := target.ParseLog([]byte(execLog)) if len(entries) != 5 { for i, ent := range entries { t.Logf("program #%v: %s\n", i, ent.P) @@ -99,11 +107,15 @@ munlockall() ` func TestParseFault(t *testing.T) { + target, err := GetTarget("linux", "amd64") + if err != nil { + t.Fatal(err) + } const execLog = `2015/12/21 12:18:05 executing program 1 (fault-call:1 fault-nth:55): gettid() getpid() ` - entries := ParseLog([]byte(execLog)) + entries := target.ParseLog([]byte(execLog)) if len(entries) != 1 { t.Fatalf("got %v programs, want 1", len(entries)) } -- cgit mrf-deployment