From acc528cbf40c42eb112d2ce66c5f778bd4a397fb Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 16 Apr 2024 16:35:18 +0200 Subject: tools/syz-linter: check t.Logf/Errorf/Fatalf messages Fix checking of Logf, it has string in 0-th arg. Add checking of t.Errorf/Fatalf. --- prog/mutation_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'prog/mutation_test.go') diff --git a/prog/mutation_test.go b/prog/mutation_test.go index 29bf7a34a..14e80a73b 100644 --- a/prog/mutation_test.go +++ b/prog/mutation_test.go @@ -191,7 +191,7 @@ func TestSizeMutateArg(t *testing.T) { limit := uint64(1< limit { - t.Fatalf("Invalid argument value: %d. (arg size: %d; max value: %d)", val, arg.Size(), limit) + t.Fatalf("invalid argument value: %d. (arg size: %d; max value: %d)", val, arg.Size(), limit) } }) } @@ -207,7 +207,7 @@ func TestClone(t *testing.T) { data := p.Serialize() data1 := p1.Serialize() if !bytes.Equal(data, data1) { - t.Fatalf("program changed after clone\noriginal:\n%s\n\nnew:\n%s\n", data, data1) + t.Fatalf("program changed after clone\noriginal:\n%s\n\nnew:\n%s", data, data1) } } } @@ -226,7 +226,7 @@ func TestMutateRandom(t *testing.T) { p1.Mutate(rs, 10, ct, nil, nil) data := p.Serialize() if !bytes.Equal(data0, data) { - t.Fatalf("program changed after mutate\noriginal:\n%s\n\nnew:\n%s\n", + t.Fatalf("program changed after mutate\noriginal:\n%s\n\nnew:\n%s", data0, data) } data1 := p1.Serialize() @@ -234,7 +234,7 @@ func TestMutateRandom(t *testing.T) { continue } if _, err := target.Deserialize(data1, NonStrict); err != nil { - t.Fatalf("Deserialize failed after Mutate: %v\n%s", err, data1) + t.Fatalf("deserialize failed after mutate: %v\n%s", err, data1) } continue next } -- cgit mrf-deployment