From e54e9781a4e043b3140b0c908ba4f4e469fd317e Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Sun, 26 Apr 2020 14:14:14 +0200 Subject: prog: remove Dir from Type Having Dir is Type is handy, but forces us to duplicate lots of types. E.g. if a struct is referenced as both in and out, then we need to have 2 copies and 2 copies of structs/types it includes. If also prevents us from having the struct type as struct identity (because we can have up to 3 of them). Revert to the old way we used to do it: propagate Dir as we walk syscall arguments. This moves lots of dir passing from pkg/compiler to prog package. Now Arg contains the dir, so once we build the tree, we can use dirs as before. Reduces size of sys/linux/gen/amd64.go from 6058336 to 5661150 (-6.6%). Update #1580 --- prog/hints.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'prog/hints.go') diff --git a/prog/hints.go b/prog/hints.go index 9a5675b1b..be2b371f2 100644 --- a/prog/hints.go +++ b/prog/hints.go @@ -82,7 +82,7 @@ func (p *Prog) MutateWithHints(callIndex int, comps CompMap, exec func(p *Prog)) func generateHints(compMap CompMap, arg Arg, exec func()) { typ := arg.Type() - if typ == nil || typ.Dir() == DirOut { + if typ == nil || arg.Dir() == DirOut { return } switch t := typ.(type) { -- cgit mrf-deployment