From 40723a067e2216f643485b732f90202b38b59e4b Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 24 Jan 2017 10:51:38 +0100 Subject: prog: validate deserialized programs The optimization change removed validation too aggressively. We do need program validation during deserialization, because we can get bad programs from corpus or hub. Restore program validation after deserialization. --- prog/encodingexec.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'prog/encodingexec.go') diff --git a/prog/encodingexec.go b/prog/encodingexec.go index 5afd83fd6..304440d0e 100644 --- a/prog/encodingexec.go +++ b/prog/encodingexec.go @@ -35,8 +35,10 @@ const ( // SerializeForExec serializes program p for execution by process pid into the provided buffer. // If the provided buffer is too small for the program an error is returned. func (p *Prog) SerializeForExec(buffer []byte, pid int) error { - if err := p.validate(); err != nil { - panic(fmt.Errorf("serializing invalid program: %v", err)) + if debug { + if err := p.validate(); err != nil { + panic(fmt.Errorf("serializing invalid program: %v", err)) + } } var instrSeq uintptr w := &execContext{ -- cgit mrf-deployment