From f9f80dd43751ab5172bf048d3213ba2ba73b77e4 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 10 Dec 2019 12:20:50 +0100 Subject: pkg/report: use --git-min-percent=15 for get_maintainer.pl Update #1441 --- pkg/report/linux.go | 6 ++++-- pkg/vcs/linux.go | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) (limited to 'pkg') diff --git a/pkg/report/linux.go b/pkg/report/linux.go index c7975e255..5eb0ae5fd 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -449,12 +449,14 @@ func (ctx *linux) getMaintainers(file string) ([]string, error) { } func (ctx *linux) getMaintainersImpl(file string, blame bool) ([]string, error) { - args := []string{"--no-n", "--no-rolestats"} + // See #1441 re --git-min-percent. + args := []string{"--no-n", "--no-rolestats", "--git-min-percent=15"} if blame { args = append(args, "--git-blame") } args = append(args, "-f", file) - output, err := osutil.RunCmd(time.Minute, ctx.kernelSrc, filepath.FromSlash("scripts/get_maintainer.pl"), args...) + script := filepath.FromSlash("scripts/get_maintainer.pl") + output, err := osutil.RunCmd(time.Minute, ctx.kernelSrc, script, args...) if err != nil { return nil, err } diff --git a/pkg/vcs/linux.go b/pkg/vcs/linux.go index 1ecad347d..62f73e3b9 100644 --- a/pkg/vcs/linux.go +++ b/pkg/vcs/linux.go @@ -184,7 +184,7 @@ func (ctx *linux) Bisect(bad, good string, trace io.Writer, pred func() (BisectR } func (ctx *linux) addMaintainers(com *Commit) { - if len(com.CC) > 3 { + if len(com.CC) > 2 { return } list := ctx.getMaintainers(com.Hash, false) @@ -195,8 +195,10 @@ func (ctx *linux) addMaintainers(com *Commit) { } func (ctx *linux) getMaintainers(hash string, blame bool) []string { + // See #1441 re --git-min-percent. args := "git show " + hash + " | " + - filepath.FromSlash("scripts/get_maintainer.pl") + " --no-n --no-rolestats" + filepath.FromSlash("scripts/get_maintainer.pl") + + " --no-n --no-rolestats --git-min-percent=20" if blame { args += " --git-blame" } -- cgit mrf-deployment