From ec0147d47fb25d0efdc677000312db1919ea0086 Mon Sep 17 00:00:00 2001 From: Michael Pratt Date: Thu, 13 Dec 2018 00:38:59 -0800 Subject: Merge pull request #874 from prattmic/bazel_version pkg/build: fix bazel version parsing --- pkg/build/build.go | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/build/build.go b/pkg/build/build.go index 7ce21e9b0..3e9e73912 100644 --- a/pkg/build/build.go +++ b/pkg/build/build.go @@ -82,8 +82,11 @@ func CompilerIdentity(compiler string) (string, error) { if compiler == "" { return "", nil } + + bazel := strings.HasSuffix(compiler, "bazel") + arg := "--version" - if strings.HasSuffix(compiler, "bazel") { + if bazel { arg = "" } output, err := osutil.RunCmd(time.Minute, "", compiler, arg) @@ -91,9 +94,19 @@ func CompilerIdentity(compiler string) (string, error) { return "", err } for _, line := range strings.Split(string(output), "\n") { - if strings.Contains(line, "Extracting Bazel") { - continue + if bazel { + // Strip extracting and log lines... + if strings.Contains(line, "Extracting Bazel") { + continue + } + if strings.HasPrefix(line, "INFO: ") { + continue + } + if strings.HasPrefix(line, "WARNING: ") { + continue + } } + return strings.TrimSpace(line), nil } return "", fmt.Errorf("no output from compiler --version") -- cgit mrf-deployment