From e3d77cf2a3cefdc0b6781c32ca3b878568a5856b Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 4 Jun 2020 22:20:22 +0200 Subject: .golangci.yml: enable godot checker A good one. Lots of fixed comments are contributed by episodic contributors. So it's good to catch these earlier. --- pkg/ast/ast.go | 4 ++-- pkg/ifuzz/pseudo.go | 4 ++-- pkg/ipc/ipc.go | 6 +++--- pkg/symbolizer/symbolizer.go | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) (limited to 'pkg') diff --git a/pkg/ast/ast.go b/pkg/ast/ast.go index 8cd7bef6e..60b984134 100644 --- a/pkg/ast/ast.go +++ b/pkg/ast/ast.go @@ -27,7 +27,7 @@ type Node interface { walk(cb func(Node)) } -// Top-level AST nodes: +// Top-level AST nodes. type NewLine struct { Pos Pos @@ -150,7 +150,7 @@ func (n *TypeDef) Info() (Pos, string, string) { return n.Pos, "type", n.Name.Name } -// Not top-level AST nodes: +// Not top-level AST nodes. type Ident struct { Pos Pos diff --git a/pkg/ifuzz/pseudo.go b/pkg/ifuzz/pseudo.go index 8ca8ef8d6..1bb171665 100644 --- a/pkg/ifuzz/pseudo.go +++ b/pkg/ifuzz/pseudo.go @@ -399,7 +399,7 @@ func (gen *generator) mov64(reg int, v uint64) { gen.imm64(v) } -// movl $v, off(%rsp) +// movl $v, off(%rsp). func (gen *generator) mov32toSPaddr(v uint32, off uint8) { gen.addr32() gen.operand32() @@ -565,7 +565,7 @@ var ports = []uint16{ 0x20, 0x21, 0xa0, 0xa1, 0x4d0, 0x4d1, // 8259 } -// sys/kvm.txt also knows this list +// sys/kvm.txt also knows this list. var msrs = []uint32{ 0x0, 0x1, 0x10, 0x11, 0x12, 0x13, 0x17, 0x1b, 0x20, 0x21, 0x28, 0x29, 0x2a, 0x2c, 0x33, 0x34, diff --git a/pkg/ipc/ipc.go b/pkg/ipc/ipc.go index 9ee7843d3..e5e6a2b30 100644 --- a/pkg/ipc/ipc.go +++ b/pkg/ipc/ipc.go @@ -27,7 +27,7 @@ import ( // Configuration flags for Config.Flags. type EnvFlags uint64 -// Note: New / changed flags should be added to parse_env_flags in executor.cc +// Note: New / changed flags should be added to parse_env_flags in executor.cc. const ( FlagDebug EnvFlags = 1 << iota // debug output from executor FlagSignal // collect feedback signals (coverage) @@ -43,7 +43,7 @@ const ( FlagEnableDevlinkPCI // setup devlink PCI device ) -// Per-exec flags for ExecOpts.Flags: +// Per-exec flags for ExecOpts.Flags. type ExecFlags uint64 const ( @@ -247,7 +247,7 @@ var rateLimit = time.NewTicker(1 * time.Second) // output: process output // info: per-call info // hanged: program hanged and was killed -// err0: failed to start the process or bug in executor itself +// err0: failed to start the process or bug in executor itself. func (env *Env) Exec(opts *ExecOpts, p *prog.Prog) (output []byte, info *ProgInfo, hanged bool, err0 error) { // Copy-in serialized program. progSize, err := p.SerializeForExec(env.in) diff --git a/pkg/symbolizer/symbolizer.go b/pkg/symbolizer/symbolizer.go index f6c6dbe78..f1f8478e9 100644 --- a/pkg/symbolizer/symbolizer.go +++ b/pkg/symbolizer/symbolizer.go @@ -1,7 +1,7 @@ // Copyright 2016 syzkaller project authors. All rights reserved. // Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file. -// TODO: strip " (discriminator N)", "constprop", "isra" from function names +// TODO: strip " (discriminator N)", "constprop", "isra" from function names. package symbolizer -- cgit mrf-deployment