From d4aacfdb59f31f4548a4f10844302a02b3801ea3 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Wed, 20 Mar 2019 10:30:57 +0100 Subject: pkg/vcs: remove unused functions Bisect is not needed after introduction of Bisecter interface. --- pkg/vcs/freebsd.go | 17 ----------------- pkg/vcs/fuchsia.go | 6 ------ 2 files changed, 23 deletions(-) (limited to 'pkg') diff --git a/pkg/vcs/freebsd.go b/pkg/vcs/freebsd.go index f007ab69f..222b15b87 100644 --- a/pkg/vcs/freebsd.go +++ b/pkg/vcs/freebsd.go @@ -3,11 +3,6 @@ package vcs -import ( - "fmt" - "io" -) - type freebsd struct { *git } @@ -17,15 +12,3 @@ func newFreeBSD(vm, dir string) *freebsd { git: newGit(dir, nil), } } - -func (ctx *freebsd) ExtractFixTagsFromCommits(baseCommit, email string) ([]*Commit, error) { - return ctx.git.ExtractFixTagsFromCommits(baseCommit, email) -} - -func (ctx *freebsd) Bisect(bad, good string, trace io.Writer, pred func() (BisectResult, error)) (*Commit, error) { - return nil, fmt.Errorf("not implemented for freebsd") -} - -func (ctx *freebsd) PreviousReleaseTags(commit string) ([]string, error) { - return nil, fmt.Errorf("not implemented for freebsd") -} diff --git a/pkg/vcs/fuchsia.go b/pkg/vcs/fuchsia.go index c04404416..7d7072e94 100644 --- a/pkg/vcs/fuchsia.go +++ b/pkg/vcs/fuchsia.go @@ -5,7 +5,6 @@ package vcs import ( "fmt" - "io" "os" "path/filepath" @@ -90,8 +89,3 @@ func (ctx *fuchsia) ListRecentCommits(baseCommit string) ([]string, error) { func (ctx *fuchsia) ExtractFixTagsFromCommits(baseCommit, email string) ([]*Commit, error) { return ctx.zircon.ExtractFixTagsFromCommits(baseCommit, email) } - -func (ctx *fuchsia) Bisect(bad, good string, trace io.Writer, pred func() (BisectResult, interface{}, error)) ( - *Commit, interface{}, error) { - return nil, nil, fmt.Errorf("not implemented for fuchsia") -} -- cgit mrf-deployment