From cc20438302bdafe6d4e1b1373a94515cd5a3ccb6 Mon Sep 17 00:00:00 2001 From: Joey Jiao Date: Wed, 15 May 2024 15:54:48 +0800 Subject: all: rename html functions to meaningful ones --- pkg/cover/html.go | 6 +++--- pkg/cover/report_test.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'pkg') diff --git a/pkg/cover/html.go b/pkg/cover/html.go index 4ff407977..ba38cd884 100644 --- a/pkg/cover/html.go +++ b/pkg/cover/html.go @@ -393,7 +393,7 @@ func (rg *ReportGenerator) convertToStats(progs []Prog) ([]fileStats, error) { return data, nil } -func (rg *ReportGenerator) DoCSVFiles(w io.Writer, params HandlerParams) error { +func (rg *ReportGenerator) DoFileCover(w io.Writer, params HandlerParams) error { var progs = fixUpPCs(rg.target.Arch, params.Progs, params.Filter) data, err := rg.convertToStats(progs) if err != nil { @@ -493,7 +493,7 @@ func groupCoverByFilePrefixes(datas []fileStats, subsystems []mgrconfig.Subsyste return d } -func (rg *ReportGenerator) DoHTMLTable(w io.Writer, params HandlerParams) error { +func (rg *ReportGenerator) DoSubsystemCover(w io.Writer, params HandlerParams) error { var progs = fixUpPCs(rg.target.Arch, params.Progs, params.Filter) data, err := rg.convertToStats(progs) if err != nil { @@ -589,7 +589,7 @@ var csvHeader = []string{ "Total PCs", } -func (rg *ReportGenerator) DoCSV(w io.Writer, params HandlerParams) error { +func (rg *ReportGenerator) DoFuncCover(w io.Writer, params HandlerParams) error { var progs = fixUpPCs(rg.target.Arch, params.Progs, params.Filter) files, err := rg.prepareFileMap(progs, params.Force, params.Debug) if err != nil { diff --git a/pkg/cover/report_test.go b/pkg/cover/report_test.go index ac0afd6c7..c021856cd 100644 --- a/pkg/cover/report_test.go +++ b/pkg/cover/report_test.go @@ -389,16 +389,16 @@ func generateReport(t *testing.T, target *targets.Target, test *Test) (*reports, return nil, err } htmlTable := new(bytes.Buffer) - if err := rg.DoHTMLTable(htmlTable, params); err != nil { + if err := rg.DoSubsystemCover(htmlTable, params); err != nil { return nil, err } _ = htmlTable csv := new(bytes.Buffer) - if err := rg.DoCSV(csv, params); err != nil { + if err := rg.DoFuncCover(csv, params); err != nil { return nil, err } csvFiles := new(bytes.Buffer) - if err := rg.DoCSVFiles(csvFiles, params); err != nil { + if err := rg.DoFileCover(csvFiles, params); err != nil { return nil, err } _ = csvFiles -- cgit mrf-deployment