From c3f154198aa4cf12b06fa6a3071b7e009d63c782 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Mon, 5 Feb 2024 11:16:54 +0100 Subject: pkg/repro: abort after 6 chunks It feels like 8 is a bit too high number. Let's stop reproduction earlier. --- pkg/repro/repro.go | 2 +- pkg/repro/repro_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'pkg') diff --git a/pkg/repro/repro.go b/pkg/repro/repro.go index 4101afa19..6a2eff44c 100644 --- a/pkg/repro/repro.go +++ b/pkg/repro/repro.go @@ -640,7 +640,7 @@ func (ctx *context) bisectProgs(progs []*prog.LogEntry, pred func([]*prog.LogEnt Pred: minimizePred, // For flaky crashes we usually end up with too many chunks. // Continuing bisection would just take a lot of time and likely produce no result. - MaxChunks: 8, + MaxChunks: 6, Logf: func(msg string, args ...interface{}) { ctx.reproLogf(3, "bisect: "+msg, args...) }, diff --git a/pkg/repro/repro_test.go b/pkg/repro/repro_test.go index fc8d9cad0..368ab3dff 100644 --- a/pkg/repro/repro_test.go +++ b/pkg/repro/repro_test.go @@ -63,7 +63,7 @@ func TestBisect(t *testing.T) { } return guilty == numGuilty, nil }) - if numGuilty > 8 && len(progs) == 0 { + if numGuilty > 6 && len(progs) == 0 { // Bisection has been aborted. continue } -- cgit mrf-deployment