From 95d024ce4254a321e35cc93ef67b1d8d6cee1d26 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 17 Feb 2023 10:51:23 +0100 Subject: pkg/cover/backend: close ELF files We seem to be missing Close calls on these. --- pkg/cover/backend/elf.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'pkg') diff --git a/pkg/cover/backend/elf.go b/pkg/cover/backend/elf.go index 328bd1768..5bc9fdfad 100644 --- a/pkg/cover/backend/elf.go +++ b/pkg/cover/backend/elf.go @@ -36,6 +36,7 @@ func elfReadSymbols(module *Module, info *symbolInfo) ([]*Symbol, error) { if err != nil { return nil, err } + defer file.Close() text := file.Section(".text") if text == nil { return nil, fmt.Errorf("no .text section in the object file") @@ -87,6 +88,7 @@ func elfReadTextRanges(module *Module) ([]pcRange, []*CompileUnit, error) { if err != nil { return nil, nil, err } + defer file.Close() text := file.Section(".text") if text == nil { return nil, nil, fmt.Errorf("no .text section in the object file") @@ -130,6 +132,7 @@ func elfReadTextData(module *Module) ([]byte, error) { if err != nil { return nil, err } + defer file.Close() text := file.Section(".text") if text == nil { return nil, fmt.Errorf("no .text section in the object file") @@ -143,6 +146,7 @@ func elfReadModuleCoverPoints(target *targets.Target, module *Module, info *symb if err != nil { return pcs, err } + defer file.Close() callRelocType := arches[target.Arch].callRelocType relaOffset := arches[target.Arch].relaOffset for _, s := range file.Sections { -- cgit mrf-deployment