From 7bd97c6ff6472db1e2ad9f279fe517cd7b5daee2 Mon Sep 17 00:00:00 2001
From: Dmitry Vyukov <dvyukov@google.com>
Date: Mon, 18 Jun 2018 19:45:45 +0200
Subject: pkg/host: better detection of supported sockets

Check socketpair.
Check non-constant socket types.
---
 pkg/host/host_linux.go | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

(limited to 'pkg')

diff --git a/pkg/host/host_linux.go b/pkg/host/host_linux.go
index 252af983c..dff8bd88d 100644
--- a/pkg/host/host_linux.go
+++ b/pkg/host/host_linux.go
@@ -37,7 +37,8 @@ func isSupported(c *prog.Syscall, sandbox string) (bool, string) {
 	if strings.HasPrefix(c.CallName, "syz_") {
 		return isSupportedSyzkall(sandbox, c)
 	}
-	if strings.HasPrefix(c.Name, "socket$") {
+	if strings.HasPrefix(c.Name, "socket$") ||
+		strings.HasPrefix(c.Name, "socketpair$") {
 		return isSupportedSocket(c)
 	}
 	if strings.HasPrefix(c.Name, "openat$") {
@@ -181,7 +182,24 @@ func isSupportedSocket(c *prog.Syscall) (bool, string) {
 	if err == syscall.EAFNOSUPPORT {
 		return false, "socket family is not supported (EAFNOSUPPORT)"
 	}
-	return true, ""
+	proto, ok := c.Args[2].(*prog.ConstType)
+	if !ok {
+		return true, ""
+	}
+	var typ uint64
+	if arg, ok := c.Args[1].(*prog.ConstType); ok {
+		typ = arg.Val
+	} else if arg, ok := c.Args[1].(*prog.FlagsType); ok {
+		typ = arg.Vals[0]
+	} else {
+		return true, ""
+	}
+	fd, err = syscall.Socket(int(af.Val), int(typ), int(proto.Val))
+	if fd != -1 {
+		syscall.Close(fd)
+		return true, ""
+	}
+	return false, err.Error()
 }
 
 func isSupportedOpenAt(c *prog.Syscall) (bool, string) {
-- 
cgit mrf-deployment