From 5cbdd9f4445514cbacadc362c2891e40b7f36072 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 2 Aug 2018 16:55:29 +0200 Subject: gometalinter: strengthen gocyclo limit Strengthen gocycle limit 35->24! Yay! No more jumbo functions! Fixes #538 --- pkg/host/host_linux.go | 4 ++++ pkg/report/linux.go | 2 ++ 2 files changed, 6 insertions(+) (limited to 'pkg') diff --git a/pkg/host/host_linux.go b/pkg/host/host_linux.go index 6d7c9c516..16be1d578 100644 --- a/pkg/host/host_linux.go +++ b/pkg/host/host_linux.go @@ -122,6 +122,10 @@ var ( filesystemsOnce sync.Once ) +// The function is lengthy as it handles all pseudo-syscalls, +// but it does not seem to cause comprehension problems as there is no shared state. +// Splitting this per-syscall will only increase code size. +// nolint: gocyclo func isSupportedSyzkall(sandbox string, c *prog.Syscall) (bool, string) { switch c.CallName { case "syz_open_dev": diff --git a/pkg/report/linux.go b/pkg/report/linux.go index 892c6d53a..03c9e4a4a 100644 --- a/pkg/report/linux.go +++ b/pkg/report/linux.go @@ -162,6 +162,8 @@ func (ctx *linux) Parse(output []byte) *Report { return rep } +// Yes, it is complex, but all state and logic are tightly coupled. It's unclear how to simplify it. +// nolint: gocyclo func (ctx *linux) parseOutput(output []byte) ( oops *oops, startPos, endPos int, logReport, consoleReport, consoleReportReliable []byte, -- cgit mrf-deployment