From 5bc702124e611ab9f14217760c163fd8b4e10a7d Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 18 Nov 2019 18:23:01 +0100 Subject: pkg/bisect: add more logging for build signatures It seems that some signatures that should be equal are not (or something else is going on). Add some logging for transparency. --- pkg/bisect/bisect.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'pkg') diff --git a/pkg/bisect/bisect.go b/pkg/bisect/bisect.go index 5a6197c32..c3a80a3e8 100644 --- a/pkg/bisect/bisect.go +++ b/pkg/bisect/bisect.go @@ -222,6 +222,8 @@ func (env *env) bisect() (*Result, error) { res.Report = testRes.rep if testRes.kernelSign != "" && len(com.Parents) == 1 { if prevRes := results[com.Parents[0]]; prevRes != nil { + env.log("kernel signature: %v", testRes.kernelSign) + env.log("previous signature: %v", prevRes.kernelSign) res.NoopChange = testRes.kernelSign == prevRes.kernelSign } } @@ -314,6 +316,9 @@ func (env *env) test() (*testResult, error) { } _, kernelSign, err := env.inst.BuildKernel(bisectEnv.Compiler, cfg.Kernel.Userspace, cfg.Kernel.Cmdline, cfg.Kernel.Sysctl, bisectEnv.KernelConfig) + if kernelSign != "" { + env.log("kernel signature: %v", kernelSign) + } env.buildTime += time.Since(buildStart) res := &testResult{ verdict: vcs.BisectSkip, -- cgit mrf-deployment