From 45ca68ec31e01357b475d7d4baa16686952aa57a Mon Sep 17 00:00:00 2001 From: Joey Jiao Date: Wed, 17 Mar 2021 10:39:27 +0800 Subject: pkg/cover: reduce dom elements in fileContents Issue: #2495 --- pkg/cover/html.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/cover/html.go b/pkg/cover/html.go index b21b7a95a..6b99060b8 100644 --- a/pkg/cover/html.go +++ b/pkg/cover/html.go @@ -304,16 +304,20 @@ func fileContents(file *file, lines [][]byte, haveProgs bool) string { var buf bytes.Buffer lineCover := perLineCoverage(file.covered, file.uncovered) htmlReplacer := strings.NewReplacer(">", ">", "<", "<", "&", "&", "\t", " ") - for i, ln := range lines { + buf.WriteString("
") + for i := range lines { if haveProgs { prog, count := "", " " if line := file.lines[i+1]; len(line.progCount) != 0 { prog = fmt.Sprintf("onclick='onProgClick(%v)'", line.progIndex) count = fmt.Sprintf("% 5v", len(line.progCount)) + buf.WriteString(fmt.Sprintf("%v ", prog, count)) } - buf.WriteString(fmt.Sprintf("%v ", prog, count)) + buf.WriteByte('\n') } - + } + buf.WriteString("") + for i, ln := range lines { start := 0 cover := append(lineCover[i+1], lineCoverChunk{End: backend.LineEnd}) for _, cov := range cover { @@ -341,6 +345,7 @@ func fileContents(file *file, lines [][]byte, haveProgs bool) string { } buf.WriteByte('\n') } + buf.WriteString("
") return buf.String() } -- cgit mrf-deployment