From 3f9ec663653495bfaeeb0a2f2dfce01f2820bb01 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Thu, 13 Dec 2018 12:22:49 +0100 Subject: pkg/report: relaxed gvisor OOM suppressions Existing ones don't match actual gvisor output after address mangling. Not matching exact context in parens should be good enough re false positives. --- pkg/report/gvisor.go | 6 +++--- pkg/report/testdata/gvisor/report/17 | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 pkg/report/testdata/gvisor/report/17 (limited to 'pkg') diff --git a/pkg/report/gvisor.go b/pkg/report/gvisor.go index f4b478929..c2d33f7e2 100644 --- a/pkg/report/gvisor.go +++ b/pkg/report/gvisor.go @@ -22,9 +22,9 @@ func ctorGvisor(target *targets.Target, kernelSrc, kernelObj string, suppressions := []string{ "fatal error: runtime: out of memory", "fatal error: runtime: cannot allocate memory", - "panic: ptrace sysemu failed: no such process", // OOM kill - `panic: ptrace set fpregs \(&{.*}\) failed: no such process`, // OOM kill - `panic: ptrace set regs \(&{.*}\) failed: no such process`, // OOM kill + "panic: ptrace sysemu failed: no such process", // OOM kill + `panic: ptrace set fpregs \(.*\) failed: no such process`, // OOM kill + `panic: ptrace set regs \(.*\) failed: no such process`, // OOM kill "panic: failed to start executor binary", "panic: executor failed: pthread_create failed", "panic: error mapping run data: error mapping runData: cannot allocate memory", diff --git a/pkg/report/testdata/gvisor/report/17 b/pkg/report/testdata/gvisor/report/17 new file mode 100644 index 000000000..1da86dbdd --- /dev/null +++ b/pkg/report/testdata/gvisor/report/17 @@ -0,0 +1,16 @@ +TITLE: panic: ptrace set fpregs (ADDR) failed: no such process +SUPPRESSED: Y + +panic: ptrace set fpregs (0xc000dd9300) failed: no such process + +goroutine 29103 [running]: +gvisor.googlesource.com/gvisor/pkg/sentry/platform/ptrace.(*subprocess).switchToApp(0xc000636780, 0xc00061e780, 0xd2c720, 0xc00061d560, 0xc000ce9e00) + pkg/sentry/platform/ptrace/subprocess.go:486 +0x9e7 +gvisor.googlesource.com/gvisor/pkg/sentry/platform/ptrace.(*context).Switch(0xc00061e780, 0xd1e340, 0xc000636780, 0xd2c720, 0xc00061d560, 0x7f57ffffffff, 0x0, 0x0, 0x0, 0x0) + pkg/sentry/platform/ptrace/ptrace.go:102 +0x74 +gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*runApp).execute(0x0, 0xc000489500, 0xd119c0, 0x0) + pkg/sentry/kernel/task_run.go:205 +0x348 +gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*Task).run(0xc000489500, 0x108) + pkg/sentry/kernel/task_run.go:91 +0x149 +created by gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*Task).Start + pkg/sentry/kernel/task_start.go:279 +0xfe -- cgit mrf-deployment