From 3255c6513f118900b5c41e9cf7a93c09118e2a29 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Thu, 5 Dec 2024 11:18:38 +0100 Subject: pkg/runtest: fail on cross-platform SYZFAIL reports Previously, cross-platform invocations of `syz-executor test` were ignored in the case of a SYZFAIL, and the test was still marked as PASS. Explicitly report a test failure instead. --- pkg/runtest/executor_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'pkg') diff --git a/pkg/runtest/executor_test.go b/pkg/runtest/executor_test.go index 4d803283a..25596646a 100644 --- a/pkg/runtest/executor_test.go +++ b/pkg/runtest/executor_test.go @@ -8,6 +8,7 @@ import ( "fmt" "math/rand" "runtime" + "strings" "testing" "time" @@ -44,7 +45,11 @@ func TestExecutor(t *testing.T) { if sysTarget.Arch == runtime.GOARCH || sysTarget.VMArch == runtime.GOARCH { t.Fatal(err) } - t.Skipf("skipping, cross-arch binary failed: %v", err) + if strings.Contains(err.Error(), "SYZFAIL:") { + t.Fatal(err) + } else { + t.Skipf("skipping, cross-arch binary failed: %v", err) + } } }) } -- cgit mrf-deployment