From 1c80ed9aeb36281de48d65ebde17fd5ed8494d33 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Fri, 11 Apr 2025 14:36:33 +0200 Subject: pkg/manager: disable fault injection during diff fuzzing It may be introducing false positives into the process of determining whether the bug affects the base kernel. Let's stay on the safe side and not do it for now. --- pkg/manager/diff.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/manager/diff.go b/pkg/manager/diff.go index 229868ff9..781ac0152 100644 --- a/pkg/manager/diff.go +++ b/pkg/manager/diff.go @@ -416,9 +416,8 @@ func (kc *kernelContext) setupFuzzer(features flatrpc.Feature, syscalls map[*pro fuzzerObj := fuzzer.NewFuzzer(kc.ctx, &fuzzer.Config{ Corpus: corpusObj, Coverage: kc.cfg.Cover, - // TODO: it may be unstable between different revisions though. - // For now it's only kept true because it seems to increase repro chances in local runs (???). - FaultInjection: true, + // Fault injection may bring instaibility into bug reproducibility, which may lead to false positives. + FaultInjection: false, Comparisons: features&flatrpc.FeatureComparisons != 0, Collide: true, EnabledCalls: syscalls, -- cgit mrf-deployment