From faed73b705cd066381011120625cd0cfd7028879 Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 21 Mar 2024 18:19:34 +0100 Subject: pkg/vcs: remove parentheses from email tests There's unfortunately no consistency in how mail.ParseAddress reacts to parentheses in display names. Versions before 1.22 used to keep them, 1.22+ cut them out. For syzbot operation the difference is not very significant, but it makes our tests too version dependent. Let's just omit parentheses from the test cases. --- pkg/vcs/vcs_test.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'pkg/vcs') diff --git a/pkg/vcs/vcs_test.go b/pkg/vcs/vcs_test.go index 2cee5e12d..aeccb3149 100644 --- a/pkg/vcs/vcs_test.go +++ b/pkg/vcs/vcs_test.go @@ -233,24 +233,24 @@ func TestFileLink(t *testing.T) { func TestParse(t *testing.T) { // nolint: lll - test1 := []byte(`Foo (Maintainer) Bar (maintainer:KERNEL) - Foo Bar(Reviewer) (reviewer:KERNEL) + test1 := []byte(`Foo Bar (maintainer:KERNEL) + Foo Bar (reviewer:KERNEL) (open list:FOO) "Supporter Foo" (supporter:KERNEL) linux-kernel@vger.kernel.org (open list)`) // nolint: lll - test2 := []byte(`Foo (Maintainer) Bar (maintainer:KERNEL) - Foo Bar(Reviewer) (reviewer:KERNEL) + test2 := []byte(`Foo Bar (maintainer:KERNEL) + Foo Bar (reviewer:KERNEL) "Supporter Foo" (supporter:KERNEL) linux-kernel@vger.kernel.org (open list)`) - maintainers1 := Recipients{{mail.Address{Name: "Foo (Maintainer) Bar", Address: "a@email.com"}, To}, - {mail.Address{Name: "Foo Bar(Reviewer)", Address: "b@email.com"}, Cc}, + maintainers1 := Recipients{{mail.Address{Name: "Foo Bar", Address: "a@email.com"}, To}, + {mail.Address{Name: "Foo Bar", Address: "b@email.com"}, Cc}, {mail.Address{Name: "Supporter Foo", Address: "c@email.com"}, To}, {mail.Address{Name: "", Address: "linux-kernel@vger.kernel.org"}, Cc}, {mail.Address{Name: "", Address: "somelist@list.com"}, To}} - maintainers2 := Recipients{{mail.Address{Name: "Foo (Maintainer) Bar", Address: "a@email.com"}, To}, - {mail.Address{Name: "Foo Bar(Reviewer)", Address: "b@email.com"}, Cc}, + maintainers2 := Recipients{{mail.Address{Name: "Foo Bar", Address: "a@email.com"}, To}, + {mail.Address{Name: "Foo Bar", Address: "b@email.com"}, Cc}, {mail.Address{Name: "Supporter Foo", Address: "c@email.com"}, To}, {mail.Address{Name: "", Address: "linux-kernel@vger.kernel.org"}, To}} -- cgit mrf-deployment