From f7b01f08a31f0ab533410a3ba3b74f781674e059 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 7 Jul 2020 09:06:48 +0200 Subject: pkg/vcs: fix config bisection tests more config-bisect.pl uses bash-isms and can't run on non-linux. It also silently ignores all errors which made failures very obscure -- the script happily succeeds in presence of any errors. So the test failed later reading .config. Use "set -eu" to not fail silently. Also trace all config-bisect.pl invocations and output. good/bad decisions are important and we always log them in the normal bisection. --- pkg/vcs/testdata/linux/config-bisect.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'pkg/vcs/testdata/linux') diff --git a/pkg/vcs/testdata/linux/config-bisect.pl b/pkg/vcs/testdata/linux/config-bisect.pl index 3388e3da0..29a488e58 100755 --- a/pkg/vcs/testdata/linux/config-bisect.pl +++ b/pkg/vcs/testdata/linux/config-bisect.pl @@ -1,8 +1,10 @@ -#!/bin/sh +#!/bin/bash # Copyright 2020 syzkaller project authors. All rights reserved. # Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file. # config-bisect.pl -l ctx.git.dir -r -b ctx.git.dir kernelBaselineConfig kernelConfig +set -eu + if [ "$3" == "-r" ] then baseline=`cat $6` -- cgit mrf-deployment