From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/repro/repro_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'pkg/repro') diff --git a/pkg/repro/repro_test.go b/pkg/repro/repro_test.go index 3fd9eb1b3..9b639cd7d 100644 --- a/pkg/repro/repro_test.go +++ b/pkg/repro/repro_test.go @@ -11,6 +11,7 @@ import ( "github.com/google/syzkaller/pkg/csource" "github.com/google/syzkaller/prog" + "github.com/google/syzkaller/sys/targets" ) func initTest(t *testing.T) (*rand.Rand, int) { @@ -92,7 +93,7 @@ func TestSimplifies(t *testing.T) { } var check func(opts csource.Options, i int) check = func(opts csource.Options, i int) { - if err := opts.Check("linux"); err != nil { + if err := opts.Check(targets.Linux); err != nil { t.Fatalf("opts are invalid: %v", err) } if i == len(cSimplifies) { -- cgit mrf-deployment