From 9018a3379f7ea7affb251bf8a319d9a8c5abadab Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 8 Jun 2023 17:57:33 +0200 Subject: syz-manager: don't report all pkg/repro errors on shutdown Otherwise we're getting "repro failed: all VMs failed to boot" pkg/repro errors if a sykaller instance is shutting down. --- pkg/repro/repro.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'pkg/repro') diff --git a/pkg/repro/repro.go b/pkg/repro/repro.go index dc680cbb5..87b9eaa4c 100644 --- a/pkg/repro/repro.go +++ b/pkg/repro/repro.go @@ -543,12 +543,14 @@ func (ctx *context) testWithInstance(callback func(execInterface) (rep *instance return true, nil } +var ErrNoVMs = errors.New("all VMs failed to boot") + // A helper method for testWithInstance. func (ctx *context) runOnInstance(callback func(execInterface) (rep *instance.RunResult, err error)) (*instance.RunResult, error) { inst := <-ctx.instances if inst == nil { - return nil, fmt.Errorf("all VMs failed to boot") + return nil, ErrNoVMs } defer ctx.returnInstance(inst) return callback(inst.execProg) -- cgit mrf-deployment