From 7a53e7e35da7468b5a6291fa3b5e1db4bcdf402f Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 14 Nov 2017 09:41:55 +0100 Subject: pkg/report: combine report data into a struct Parse returns 5 variables now. Later we may want to add crash "priority". Introduce Report struct that holds all report data. --- pkg/repro/repro.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'pkg/repro') diff --git a/pkg/repro/repro.go b/pkg/repro/repro.go index 699f0d7c3..b6b6a908e 100644 --- a/pkg/repro/repro.go +++ b/pkg/repro/repro.go @@ -74,10 +74,11 @@ func Run(crashLog []byte, cfg *mgrconfig.Config, reporter report.Reporter, vmPoo if len(entries) == 0 { return nil, fmt.Errorf("crash log does not contain any programs") } - crashDesc, _, crashStart, _, _ := reporter.Parse(crashLog) - if crashDesc == "" { - crashStart = len(crashLog) // assuming VM hanged - crashDesc = "hang" + crashStart := len(crashLog) // assuming VM hanged + crashDesc := "hang" + if rep := reporter.Parse(crashLog); rep != nil { + crashStart = rep.Start + crashDesc = rep.Desc } ctx := &context{ -- cgit mrf-deployment