From c69659e3523cba959b06e05d4a5e44e52c31ddd2 Mon Sep 17 00:00:00 2001 From: Anton Lindqvist Date: Sat, 9 Feb 2019 17:23:53 +0100 Subject: openbsd: remove shorten report logic (#986) A line length of 79 in the ddb output does not necessarily imply that the following line is a continuation of the current line. Since there's no way to distinguish between ordinary and continuation lines, it could end up corrupting the report by joining two lines that are disjoint[1]. Instead, disable line wrapping in ddb. If we want some kind of wrapping in the future it's easier done by pkg/report. [1] https://syzkaller.appspot.com/bug?extid=03f7377a9848d7d008c9 --- pkg/report/testdata/openbsd/report/6 | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'pkg/report/testdata') diff --git a/pkg/report/testdata/openbsd/report/6 b/pkg/report/testdata/openbsd/report/6 index b9ec04b39..7d7696567 100644 --- a/pkg/report/testdata/openbsd/report/6 +++ b/pkg/report/testdata/openbsd/report/6 @@ -7,10 +7,8 @@ TITLE: pool: double put: lockfpl panic() at panic+0x147 pool_do_put(ffffff001692bd18,ffffffff81ec0850) at pool_do_put+0x2e2 pool_put(ffffff0016933440,ffff80000e3793e8) at pool_put+0x37 - lf_advlock(40,ffffff001dc251c8,2,ffff80000e3793e8,ffffffff81df26c0,200000040) a - t lf_advlock+0x270 - VOP_ADVLOCK(ffffff0015a96da8,ffff80000e2a3080,3,ffffff001f7ca350,3) at VOP_ADVL - OCK+0x67 + lf_advlock(40,ffffff001dc251c8,2,ffff80000e3793e8,ffffffff81df26c0,200000040) at lf_advlock+0x270 + VOP_ADVLOCK(ffffff0015a96da8,ffff80000e2a3080,3,ffffff001f7ca350,3) at VOP_ADVLOCK+0x67 closef(ffff80000e2a3080,ffffff001f7ca350) at closef+0xaf fdfree(ffff80000e27c008) at fdfree+0x98 exit1(ffff80000e3795c0,ffff80000e2a3080,ffff80000e27c008) at exit1+0x226 @@ -26,10 +24,8 @@ TITLE: pool: double put: lockfpl panic() at panic+0x147 pool_do_put(ffffff001692bd18,ffffffff81ec0850) at pool_do_put+0x2e2 pool_put(ffffff0016933440,ffff80000e3793e8) at pool_put+0x37 - lf_advlock(40,ffffff001dc251c8,2,ffff80000e3793e8,ffffffff81df26c0,200000040) a - t lf_advlock+0x270 - VOP_ADVLOCK(ffffff0015a96da8,ffff80000e2a3080,3,ffffff001f7ca350,3) at VOP_ADVL - OCK+0x67 + lf_advlock(40,ffffff001dc251c8,2,ffff80000e3793e8,ffffffff81df26c0,200000040) at lf_advlock+0x270 + VOP_ADVLOCK(ffffff0015a96da8,ffff80000e2a3080,3,ffffff001f7ca350,3) at VOP_ADVLOCK+0x67 closef(ffff80000e2a3080,ffffff001f7ca350) at closef+0xaf fdfree(ffff80000e27c008) at fdfree+0x98 exit1(ffff80000e3795c0,ffff80000e2a3080,ffff80000e27c008) at exit1+0x226 -- cgit mrf-deployment