From db33b3dda2268ab83d456651df956500b1caea5f Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Mon, 11 Jul 2022 13:26:59 +0000 Subject: pkg/report: don't decompile opcodes for hanged reports It doesn't bring any extra value and only makes the reports bigger. Don't do such decompilation for hang-related reports. Refactor the opcode tests to rely more on the more generic NewReporter constructor. --- pkg/report/testdata/linux/decompile/amd64/2.out | 21 --------------------- 1 file changed, 21 deletions(-) (limited to 'pkg/report/testdata/linux') diff --git a/pkg/report/testdata/linux/decompile/amd64/2.out b/pkg/report/testdata/linux/decompile/amd64/2.out index 96ae47e75..7559caf25 100644 --- a/pkg/report/testdata/linux/decompile/amd64/2.out +++ b/pkg/report/testdata/linux/decompile/amd64/2.out @@ -162,24 +162,3 @@ R13: 0000000000000000 R14: ffff8880b9c55de8 R15: 0000000000000001 worker_thread+0x658/0x11f0 kernel/workqueue.c:2422 kthread+0x3e5/0x4d0 kernel/kthread.c:319 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 ----------------- -Code disassembly (best guess): - 0: 1d ad 91 bc 7e sbb $0x7ebc91ad,%eax - 5: 65 8b 05 a6 91 bc 7e mov %gs:0x7ebc91a6(%rip),%eax # 0x7ebc91b2 - c: a9 00 ff ff 00 test $0xffff00,%eax - 11: 74 45 je 0x58 - 13: bf 01 00 00 00 mov $0x1,%edi - 18: e8 15 2a 09 00 callq 0x92a32 - 1d: e8 50 84 35 00 callq 0x358472 - 22: fb sti - 23: 65 8b 05 88 91 bc 7e mov %gs:0x7ebc9188(%rip),%eax # 0x7ebc91b2 -* 2a: 85 c0 test %eax,%eax <-- trapping instruction - 2c: 74 58 je 0x86 - 2e: 5b pop %rbx - 2f: 5d pop %rbp - 30: c3 retq - 31: 65 8b 05 d6 98 bc 7e mov %gs:0x7ebc98d6(%rip),%eax # 0x7ebc990e - 38: 85 c0 test %eax,%eax - 3a: 75 a2 jne 0xffffffde - 3c: 0f 0b ud2 - 3e: eb 9e jmp 0xffffffde -- cgit mrf-deployment