From b599f2fcc734e2183016a340d4f6fc2891d8e41f Mon Sep 17 00:00:00 2001 From: Aleksandr Nogikh Date: Thu, 19 Aug 2021 13:12:01 +0000 Subject: pkg/report: make opcode decompilation more intelligent Skip Code: lines that refer to user-space. Skip code listings where the trapping instruction is an intentionally invalid one (this happens in WARNINGs and most of BUG reports). Decompilation of such code fragments provides no value to the user. Add new tests and update the existing ones. Closes #2709 and #2710. --- pkg/report/testdata/linux/decompile/arm/0.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/report/testdata/linux/decompile/arm') diff --git a/pkg/report/testdata/linux/decompile/arm/0.out b/pkg/report/testdata/linux/decompile/arm/0.out index 49a85c720..710c1edbd 100644 --- a/pkg/report/testdata/linux/decompile/arm/0.out +++ b/pkg/report/testdata/linux/decompile/arm/0.out @@ -112,4 +112,4 @@ Code disassembly (best guess): 4: e2853020 add r3, r5, #32 8: e1a02000 mov r2, r0 c: e2422008 sub r2, r2, #8 - 10: e5034020 str r4, [r3, #-32] ; 0xffffffe0 <-- trapping instruction +* 10: e5034020 str r4, [r3, #-32] ; 0xffffffe0 <-- trapping instruction -- cgit mrf-deployment