From e6e35dba937599d098fc034eff2686e5ddc409e9 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Mon, 26 Oct 2020 10:51:06 +0100 Subject: sys/targets: add OS/Arch name consts We use strings to identify OS/Arch. These strings are duplicated throughout the code base massively. golangci-lint points to possiblity of typos and duplication. We already had to define these names in pkg/csource and disable checking for prog package. A future change triggers such warnings in another package. Add OS/Arch name consts to sys/targets so that they can be used to refer to OS/Arch. Use the consts everywhere. --- pkg/report/linux_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'pkg/report/linux_test.go') diff --git a/pkg/report/linux_test.go b/pkg/report/linux_test.go index 2e31ee755..d1b343efe 100644 --- a/pkg/report/linux_test.go +++ b/pkg/report/linux_test.go @@ -9,12 +9,13 @@ import ( "github.com/google/syzkaller/pkg/mgrconfig" "github.com/google/syzkaller/pkg/symbolizer" + "github.com/google/syzkaller/sys/targets" ) func TestLinuxIgnores(t *testing.T) { cfg := &mgrconfig.Config{ - TargetOS: "linux", - TargetArch: "amd64", + TargetOS: targets.Linux, + TargetArch: targets.AMD64, } reporter, err := NewReporter(cfg) if err != nil { -- cgit mrf-deployment